[#4888] improvement(core): Add the implementations for getFileLocation interface in core module
#4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
force-pushed
the
add-impl-for-get-file-location-in-core
branch
from
edd58c6
to
158042f
Compare
|
@jerryshao This PR is ready for review, please take a look when you have time, thanks. |
jerryshao
reviewed
Sep 9, 2024
core/src/main/java/org/apache/gravitino/listener/api/event/GetFileLocationEvent.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Sep 10, 2024
core/src/main/java/org/apache/gravitino/listener/api/event/GetFileLocationEvent.java
Show resolved
Hide resolved
jerryshao
reviewed
Sep 10, 2024
core/src/main/java/org/apache/gravitino/listener/api/event/GetFileLocationFailureEvent.java
Show resolved
Hide resolved
jerryshao
reviewed
Sep 10, 2024
core/src/main/java/org/apache/gravitino/listener/api/event/GetFileLocationFailureEvent.java
Show resolved
Hide resolved
jerryshao
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the implementations for
getFileLocationinterface in Core module.Why are the changes needed?
Fix: #4888
How was this patch tested?
Add some UTs.