[#4927] improvement(catalog): extract a common HMS module #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
force-pushed
the
hms-module
branch
4 times, most recently
from
326ec7f
to
6fcf97a
Compare
mchades
force-pushed
the
hms-module
branch
2 times, most recently
from
56e46d0
to
9ae4544
Compare
jerryshao
reviewed
Sep 13, 2024
| datanucleus-core = "4.1.17" | ||
| datanucleus-api-jdo = "4.2.4" | ||
| datanucleus-rdbms = "4.1.19" | ||
| datanucleus-jdo = "3.2.0-m3" |
jerryshao
reviewed
Sep 13, 2024
| sd.getNumBuckets(), | ||
| sd.getBucketCols().stream().map(NamedReference::field).toArray(Expression[]::new)); | ||
| } | ||
| Distribution distribution = ConvertUtil.getDistribution(table); |
There was a problem hiding this comment.
CovertUtil seems not so reasonable, maybe "HiveUtil" or "HiveTableUtil", "HiveTableConverter"?
There was a problem hiding this comment.
renamed to HiveTableConverter
jerryshao
reviewed
Sep 13, 2024
| import org.apache.gravitino.exceptions.NoSuchPartitionException; | ||
| import org.apache.gravitino.hms.miniHMS.MiniHiveMetastoreService; |
There was a problem hiding this comment.
Can we change the package name to "o.a.g.hive.hms.xxx", it is weird that the package name has uppercase letters...
jerryshao
reviewed
Sep 13, 2024
| @@ -16,7 +16,7 @@ | |||
| * specific language governing permissions and limitations | |||
| * under the License. | |||
| */ | |||
| package org.apache.gravitino.catalog.hive.dyn; | |||
| package org.apache.gravitino.hms.dyn; | |||
There was a problem hiding this comment.
I would change to "xxx.hive.dyn"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
extract a common HMS module
Why are the changes needed?
Fix: #4927
Does this PR introduce any user-facing change?
no
How was this patch tested?
CI passed