HADOOP-15844. Tag S3GuardTool entry points as LimitedPrivate/Evolving #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
What's the difference you see between LimitedPrivate("management tools") and Public? When things are LimitedPrivate("HBase") there's a specific community that we know to coordinate with. With "management tools" it's arbitrarily open, and I don't know what the compatibility guarantees we need to hold to are. I know with Hadoop 3's compatibility we technically violated compatibility guidelines with the original metrics framework being removed before it had been deprecated for a full release, because metrics were also seen as a similar "administrative" or "auxiliary" interface and it didn't need to really be "public". If we're doing that again, I think we can still set expectations more clearly. |
|
We've had some LimitedPrivate("management tools") elsewhere, while DistCP copyListing is "LimitedPrivate("Distcp support tools")" it's effectively saying "its a lot less stable than other things" , but there is some expectation that it may be used externally There's a limited number of people who do management tools -they know our email addresses. What I don't want to do is say this is only for one specific project as that's a bit dictatorial too.
Maybe: add something about management tools in the compatibility specs: they may be public but unstable, and you get to track the code |
steveloughran
added
the
fs/s3
|
Tracked down where the management tools ref was used already org.apache.hadoop.conf.ReconfigurationTaskStatus Discussion here was to tell hadoop developers that this was used in places, and avoided us saying this was hard coded to any specific product |
|
@mackrorysd do you want to revisit this? It's to tell us developers working on the class that this is sometimes used directly by specific tools and they need to take care when changing things |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…tional arguments (apache#1041)
…ent-tools")/evolving Change-Id: Ic58bbd917da901a1bd2322ae0f41ca00e60dcc06
steveloughran
force-pushed
the
s3/HADOOP-15844-S3GuardTool
branch
from
f0a251c
to
17e5344
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
did this with the DirMarker patch. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking
S3GuardToolas LimitedPrivate("management-tools")/Evolving to reassure people using it as an API that we intend to retain it as an API for creating/destroying/maintaining S3Guard tablesTested S3 Ireland (as part of a HADOOP-16384 test run)
Change-Id: Ic58bbd917da901a1bd2322ae0f41ca00e60dcc06