HADOOP-16346: Stabilize S3A OpenSSL support #1764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilTakiar
force-pushed
the
HADOOP-16346
branch
from
c832547
to
de231a2
Compare
|
Fixed the checkstyle issues. New Testing:
|
|
🎊 +1 overall
This message was automatically generated. |
|
New Testing:
|
steveloughran
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
reran s3a tests today, saw one known failure (https://issues.apache.org/jira/browse/HADOOP-16800) , otherwise all good.
I'm +1 for this now, you've done as much due diligence as possible, once its merged in we can see if any problems arise with others
|
+1, merged in. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HADOOP-16346: Stabilize S3A OpenSSL support
Related JIRAs:
Introduces
opensslas an option forfs.s3a.ssl.channel.mode. The new option is documented and marked as experimental.Summary of changes:
wildfly-openssla runtime dependency (rather than a compile time dependency for ABFS and S3A); onlywildfly-openssl-javais needed as a compile time dependencySSLChannelMode.OpenSSLis specified inDelegatingSSLSocketFactorycore-default.xmland S3A'sperformance.mdTesting Summary:
fs.s3a.ssl.channel.modehasn't changed, so this patch doesn't expose any new default changes to usersCompleted Testing:
test.fs.s3a.sts.enabled = truemvn clean verify -Ds3guard -Ddynamodb -Dscale -Dauthfs.s3a.ssl.channel.mode = opensslITestS3ACommitterMRJob(which I presume is a flaky test)fs.s3a.ssl.channel.modetoopenssluses WildFly OpenSSL; took a jstack while running an S3A test:fs.s3a.ssl.channel.modetodefaultand without settingorg.wildfly.openssl.path, the CLI still works; confirmed that when DEBUG logs are enabled, the following log line is printed:fs.s3a.ssl.channel.modetoopenssland without settingorg.wildfly.openssl.path, the CLI fails (as expected) with the following error:fs.s3a.ssl.channel.modetoopenssland settingorg.wildfly.openssl.path(export HADOOP_OPTS="-Dorg.wildfly.openssl.path=/usr/lib/x86_64-linux-gnu/"), the CLI works (stdout is the same as above).