Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-9512. [JDK11] TestAuxServices#testCustomizedAuxServiceClassPath fails because of ClassCastException. #1806

Merged
merged 2 commits into from Jan 16, 2020

Conversation

aajisaka
Copy link
Member

@aajisaka
Copy link
Member Author

I found this change is enough to pass the tests with Java 11.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 20m 26s trunk passed
+1 💚 compile 1m 1s trunk passed
+1 💚 checkstyle 0m 26s trunk passed
+1 💚 mvnsite 0m 36s trunk passed
+1 💚 shadedclient 14m 39s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 26s trunk passed
+0 🆗 spotbugs 1m 14s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 13s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 34s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
-0 ⚠️ checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
+1 💚 mvnsite 0m 32s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 40s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 24s the patch passed
+1 💚 findbugs 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 21m 48s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
82m 19s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/1/artifact/out/Dockerfile
GITHUB PR #1806
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 240ddc86abfc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 7c5cecc
Default Java 1.8.0_232
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/1/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/1/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@adamantal
Copy link
Contributor

LGTM (non-binding)

@jojochuang
Copy link
Contributor

Generally speaking it is not recommended to use exception to handle an expected condition due to performance concerns.

But this is a test so I am ok. +1 from me thanks @adamantal for the review.

@aajisaka
Copy link
Member Author

Thanks @adamantal and @jojochuang for reviewing this!
I'll merge this after fixing the checkstyle warning (unused imports).

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 23m 41s trunk passed
+1 💚 compile 1m 18s trunk passed
+1 💚 checkstyle 0m 33s trunk passed
+1 💚 mvnsite 0m 45s trunk passed
+1 💚 shadedclient 17m 21s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 32s trunk passed
+0 🆗 spotbugs 1m 35s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 32s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 44s the patch passed
+1 💚 compile 1m 13s the patch passed
+1 💚 javac 1m 13s the patch passed
+1 💚 checkstyle 0m 26s the patch passed
+1 💚 mvnsite 0m 42s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 37s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 29s the patch passed
+1 💚 findbugs 1m 35s the patch passed
_ Other Tests _
+1 💚 unit 23m 40s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
92m 57s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/2/artifact/out/Dockerfile
GITHUB PR #1806
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5559d414d0b3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d7c4f8a
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/2/testReport/
Max. process+thread count 413 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1806/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@aajisaka aajisaka merged commit 14c2c3d into apache:trunk Jan 16, 2020
@aajisaka aajisaka deleted the YARN-9512 branch January 16, 2020 03:21
RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants