HDFS-15258. RBF: Mark Router FSCK unstable.

[aajisaka]

JIRA: https://issues.apache.org/jira/browse/HDFS-15258

Add a message to show that the feature is unstable. The APIs are already marked as @Private so I didn't touch them.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 4s	trunk passed
+1 💚	compile	0m 31s	trunk passed
+1 💚	checkstyle	0m 20s	trunk passed
+1 💚	mvnsite	0m 35s	trunk passed
+1 💚	shadedclient	16m 25s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s	trunk passed
+0 🆗	spotbugs	1m 8s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 6s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	checkstyle	0m 15s	the patch passed
+1 💚	mvnsite	0m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 13s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	the patch passed
+1 💚	findbugs	1m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 45s	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		101m 43s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1934/1/artifact/out/Dockerfile
GITHUB PR	#1934
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 9317c9e8b4e8 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 736659e
Default Java	1.8.0_242
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1934/1/testReport/
Max. process+thread count	2913 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1934/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

Thanx @aajisaka for the work.
Hope we need not to change anything in the annotation since it is Private, like marking explicitly UNSTABLE or something?
If not, Just the log shall keep us safe.
I am +1, do get this in to 3.3 branch too.

[aajisaka]

Thanks @ayushtkn for the review.

I read the following document again and found I have to add an annotation.
http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/DownstreamDev.html#Stability

If a method has no stability annotation, then it inherits its stability from its class. If a class has no stability, it inherits its stability from its package. If a package has no stability, it should be assumed to be Unstable.

org.apache.hadoop.hdfs.server.federation.router package is marked as Evolving, so the class is now Evolving. I'd like to add Unstable annotation to RouterFsck.java.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	21m 40s	trunk passed
+1 💚	compile	0m 31s	trunk passed
+1 💚	checkstyle	0m 20s	trunk passed
+1 💚	mvnsite	0m 34s	trunk passed
+1 💚	shadedclient	16m 28s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s	trunk passed
+0 🆗	spotbugs	1m 10s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 7s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 30s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	checkstyle	0m 15s	the patch passed
+1 💚	mvnsite	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 22s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 26s	the patch passed
+1 💚	findbugs	1m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 43s	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		73m 29s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1934/2/artifact/out/Dockerfile
GITHUB PR	#1934
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ec6e0b5781b6 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / f8e598f
Default Java	1.8.0_242
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1934/2/testReport/
Max. process+thread count	3081 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1934/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

Thanx for the update.
+1

[aajisaka]

Thank you, @ayushtkn