Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17039. Change scope of InternalDirOfViewFs and InodeTree to make ViewFileSystem extendable outside common package #2017

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

abhishekdas99
Copy link
Contributor

@abhishekdas99 abhishekdas99 commented May 13, 2020

The commit changes the scope to public for following classes:

  • InodeTree
  • InternalDirOfViewFs
  • NflyFSystem
  • ChRootedFileSystem

This change makes sure the ViewFileSystem class can be extended outside of hadoop-common package and that class can initialize the mount table (fsState) in its own way

…ke ViewFileSystem extendable outside common package
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 22m 14s trunk passed
+1 💚 compile 18m 20s trunk passed
+1 💚 checkstyle 0m 47s trunk passed
+1 💚 mvnsite 1m 22s trunk passed
+1 💚 shadedclient 17m 46s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 54s trunk passed
+0 🆗 spotbugs 2m 12s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 9s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 49s the patch passed
+1 💚 compile 17m 20s the patch passed
+1 💚 javac 17m 20s the patch passed
-0 ⚠️ checkstyle 0m 47s hadoop-common-project/hadoop-common: The patch generated 17 new + 68 unchanged - 13 fixed = 85 total (was 81)
+1 💚 mvnsite 1m 20s the patch passed
-1 ❌ whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 shadedclient 15m 25s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 54s the patch passed
+1 💚 findbugs 2m 15s the patch passed
_ Other Tests _
+1 💚 unit 9m 31s hadoop-common in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
115m 6s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2017/1/artifact/out/Dockerfile
GITHUB PR #2017
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux a0f391f55ab2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / d60496e
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2017/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
whitespace https://builds.apache.org/job/hadoop-multibranch/job/PR-2017/1/artifact/out/whitespace-eol.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2017/1/testReport/
Max. process+thread count 1699 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2017/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abhishekdas99 abhishekdas99 marked this pull request as draft May 14, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants