Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15539. When disallowing snapshot on a dir, throw exception if its trash root is not empty #2258

Merged
merged 3 commits into from
Sep 14, 2020
Merged

HDFS-15539. When disallowing snapshot on a dir, throw exception if its trash root is not empty #2258

merged 3 commits into from
Sep 14, 2020

Conversation

smengcl
Copy link
Contributor

@smengcl smengcl commented Aug 28, 2020

https://issues.apache.org/jira/browse/HDFS-15539

I initially intended to put the logic in SnapshotManager#resetSnapshottable.
But later I figured it makes more sense to put the check on the client side instead:

  1. Trash is more of a client-side concept.
  2. As a result of (1), it is much cleaner to add the check on the client than on the server side.

@smengcl
Add the check in DFS#disallowSnapshot.
c63e7fe 
Change-Id: I59ea03a13da7bb95b8cb0f156cf178c587865451
@smengcl smengcl added the HDFS label Aug 28, 2020
@smengcl smengcl requested a review from mukul1987 August 28, 2020 15:56
@smengcl smengcl self-assigned this Aug 28, 2020
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 15s Maven dependency ordering for branch
+1 💚 mvninstall 28m 34s trunk passed
+1 💚 compile 4m 38s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 3m 49s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 0m 58s trunk passed
+1 💚 mvnsite 2m 10s trunk passed
+1 💚 shadedclient 19m 3s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 25s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 54s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 2m 29s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 34s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 1m 56s the patch passed
+1 💚 compile 4m 10s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 4m 10s the patch passed
+1 💚 compile 3m 50s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 3m 50s the patch passed
+1 💚 checkstyle 0m 53s the patch passed
+1 💚 mvnsite 1m 55s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 51s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 18s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 45s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 5m 45s the patch passed
_ Other Tests _
+1 💚 unit 1m 57s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 110m 48s hadoop-hdfs in the patch passed.
-1 ❌ asflicense 0m 36s The patch generated 3 ASF License warnings.
224m 24s
Reason Tests
Failed junit tests hadoop.hdfs.TestGetFileChecksum
hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.TestViewDistributedFileSystem
hadoop.hdfs.TestFileChecksum
hadoop.hdfs.TestDistributedFileSystem
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/artifact/out/Dockerfile
GITHUB PR #2258
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 656e503fc62c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 4454286
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/testReport/
asflicense https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 2857 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@bshashikant
Copy link
Contributor

Thanks @smengcl for working on this,. The test failures like TestDistributedFileSystem#testGetTrashRoots look related. Can you plz verify?

@smengcl
Use LambdaTestUtils.intercept()
a62d062 
Change-Id: I0fb293abe4da0f17579467477fbbddd913a7d8d5
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 28s Maven dependency ordering for branch
+1 💚 mvninstall 28m 49s trunk passed
+1 💚 compile 4m 37s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 4m 15s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 1m 2s trunk passed
+1 💚 mvnsite 2m 14s trunk passed
+1 💚 shadedclient 19m 0s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 25s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 56s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 2m 28s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 38s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 1m 56s the patch passed
+1 💚 compile 4m 10s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 4m 10s the patch passed
+1 💚 compile 3m 46s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 3m 46s the patch passed
+1 💚 checkstyle 0m 53s the patch passed
+1 💚 mvnsite 1m 59s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 15m 50s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 20s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 47s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 7m 3s the patch passed
_ Other Tests _
+1 💚 unit 2m 18s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 77m 54s hadoop-hdfs in the patch passed.
+0 🆗 asflicense 0m 38s ASF License check generated no output?
194m 25s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestReencryption
hadoop.hdfs.server.namenode.TestFSEditLogLoader
hadoop.hdfs.server.namenode.TestNameNodeReconfigure
hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives
hadoop.hdfs.server.namenode.TestNameEditsConfigs
hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
hadoop.hdfs.server.namenode.TestFileLimit
hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile
hadoop.hdfs.TestAppendDifferentChecksum
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.server.namenode.TestCheckpoint
hadoop.hdfs.server.namenode.TestMetadataVersionOutput
hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
hadoop.hdfs.server.namenode.TestFSImageWithXAttr
hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocksWithRandomECPolicy
hadoop.hdfs.server.namenode.TestPersistentStoragePolicySatisfier
hadoop.hdfs.TestDFSStripedInputStream
hadoop.hdfs.server.namenode.TestStoragePolicySatisfierWithHA
hadoop.hdfs.server.datanode.TestDataNodeLifeline
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.server.datanode.TestDirectoryScanner
hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
hadoop.hdfs.server.datanode.TestBatchIbr
hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
hadoop.hdfs.server.namenode.TestEditLog
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.server.blockmanagement.TestBlockManager
hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
hadoop.hdfs.server.datanode.TestBlockReplacement
hadoop.hdfs.TestDFSRollback
hadoop.hdfs.TestDFSClientExcludedNodes
hadoop.hdfs.server.namenode.TestDeleteRace
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/artifact/out/Dockerfile
GITHUB PR #2258
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux ec8de439f715 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9960c01
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/testReport/
Max. process+thread count 2045 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@smengcl
Copy link
Contributor Author

smengcl commented Sep 11, 2020

Thanks @smengcl for working on this,. The test failures like TestDistributedFileSystem#testGetTrashRoots look related. Can you plz verify?

I'm checking. Probably need to add a line or two to clean up the old tests.

@smengcl
Add extra clean up for existing tests.
194b3c4 
Change-Id: Ie644ba49987112580016cf95914c2a470a47102c
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 33s Maven dependency ordering for branch
-1 ❌ mvninstall 6m 17s root in trunk failed.
-1 ❌ compile 0m 26s hadoop-hdfs-project in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌ compile 0m 25s hadoop-hdfs-project in trunk failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-0 ⚠️ checkstyle 0m 23s The patch fails to run checkstyle in hadoop-hdfs-project
-1 ❌ mvnsite 0m 17s hadoop-hdfs-client in trunk failed.
+1 💚 shadedclient 3m 6s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 51s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 2m 19s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 3m 4s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 7m 1s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 42s Maven dependency ordering for patch
+1 💚 mvninstall 2m 18s the patch passed
-1 ❌ compile 6m 7s hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌ javac 6m 7s hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌ compile 0m 22s hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-1 ❌ javac 0m 22s hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-0 ⚠️ checkstyle 0m 23s The patch fails to run checkstyle in hadoop-hdfs-project
-1 ❌ mvnsite 0m 26s hadoop-hdfs-client in the patch failed.
-1 ❌ mvnsite 0m 25s hadoop-hdfs in the patch failed.
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 shadedclient 0m 25s patch has no errors when building and testing our client artifacts.
-1 ❌ javadoc 0m 25s hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌ javadoc 0m 27s hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌ javadoc 0m 23s hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
-1 ❌ findbugs 0m 28s hadoop-hdfs-client in the patch failed.
-1 ❌ findbugs 0m 30s hadoop-hdfs in the patch failed.
_ Other Tests _
+1 💚 unit 2m 11s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 129m 33s hadoop-hdfs in the patch passed.
-1 ❌ asflicense 0m 33s The patch generated 4 ASF License warnings.
179m 16s
Reason Tests
Failed junit tests hadoop.security.TestPermissionSymlinks
hadoop.fs.permission.TestStickyBit
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.TestGetFileChecksum
hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
hadoop.hdfs.TestFileChecksum
hadoop.security.TestRefreshUserMappings
hadoop.hdfs.TestReadStripedFileWithMissingBlocks
hadoop.tools.TestJMXGet
hadoop.hdfs.server.namenode.ha.TestHAAppend
hadoop.security.TestPermission
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/Dockerfile
GITHUB PR #2258
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 3158e5f6446b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9960c01
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
mvninstall https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/buildtool-branch-checkstyle-hadoop-hdfs-project.txt
mvnsite https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
compile https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javac https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
javac https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
checkstyle https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/buildtool-patch-checkstyle-hadoop-hdfs-project.txt
mvnsite https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
mvnsite https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
findbugs https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
findbugs https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/testReport/
asflicense https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 3074 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2258/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@bshashikant
Copy link
Contributor

/retest

@smengcl smengcl merged commit 6d3312d into apache:trunk Sep 14, 2020
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@smengcl
HDFS-15539. When disallowing snapshot on a dir, throw exception if it…
54d4dcd 
…s trash root is not empty (apache#2258)

(cherry picked from commit 6d3312d)

Change-Id: Ic2c5ab1f3aee8b002e58ee254f2993981305078c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojochuang jojochuang jojochuang approved these changes

@bshashikant bshashikant bshashikant approved these changes

@mukul1987 mukul1987 Awaiting requested review from mukul1987

Assignees

@smengcl smengcl

Labels
HDFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smengcl @hadoop-yetus @bshashikant @jojochuang