Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17282. libzstd-dev should be used instead of libzstd1-dev on Ubuntu 18.04 or higher. #2336

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

tkuramoto33
Copy link
Contributor

libzstd1-dev is a transitional package on Ubuntu 18.04. It is better to use libzstd-dev instead of libzstd1-dev in the Dockerfile (dev-support/docker/Dockerfile).

I have tested this patch in a docker container, and the results are as follows:

  1. zstd version
hadoop@ac937c1afb72:~/hadoop$ sudo apt search libzstd
Sorting... Done
Full Text Search... Done
libzstd-dev/bionic-updates,bionic-security,now 1.3.3+dfsg-2ubuntu1.1 amd64 [installed]
  fast lossless compression algorithm -- development files
libzstd1/bionic-updates,bionic-security,now 1.3.3+dfsg-2ubuntu1.1 amd64 [installed]
  fast lossless compression algorithm
libzstd1-dev/bionic-updates,bionic-security 1.3.3+dfsg-2ubuntu1.1 amd64
  transitional package for libzstd-dev
  1. Is zstd enabled?

The result of cd hadoop-common-project/hadoop-common; mvn test -Dtest=TestZStandard* is shown below.

[INFO] --- maven-surefire-plugin:3.0.0-M1:test (default-test) @ hadoop-common ---
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.io.compress.zstd.TestZStandardCompressorDecompressor
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.467 s - in org.apache.hadoop.io.compress.zstd.TestZStandardCompressorDecompressor
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0

@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2336/1/console in case of problems.

@iwasakims
Copy link
Member

@tkuramoto33 Could you update Dockerfile_aarch64 too? The same change worked for aarch64 on my env.

@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2336/2/console in case of problems.

@tkuramoto33
Copy link
Contributor Author

Thank you for reviewing my patch. I have just updated Dockerfile_aarch64.

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@iwasakims iwasakims merged commit 3fc007a into apache:trunk Sep 25, 2020
@iwasakims
Copy link
Member

I merged this. Thanks for the contribution, @tkuramoto33.

@tkuramoto33 tkuramoto33 deleted the HADOOP-17282 branch September 25, 2020 05:35
bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants