HDFS-15600 Fix TestRouterQuota#testStorageTypeQuota #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After "NVDIMM" adding, we have six storage types. This fixes the related test.
goiri
approved these changes
Sep 29, 2020
ayushtkn
reviewed
Sep 29, 2020
There was a problem hiding this comment.
No failures in the build.
https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-multibranch/view/change-requests/job/PR-2347/1/testReport/
So, in the present scenario, the fix seems correct. I am +1 on it.
Just to confirm @liuml07 should we proceed with fixing the test, are you convinced that things at HDFS-15025 are good?
|
I have not had a second look at the original patch regarding compatibility, but we can merge this patch first to make test in trunk pass. If we need to make any further changes to the original NVDIMM feature eg reordering, we can also update this test again. |
ayushtkn
approved these changes
Sep 29, 2020
|
@liuml07 OK to merge? |
liuml07
approved these changes
Sep 30, 2020
|
Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After "NVDIMM" adding, we have six storage types. This
fixes the related test.