Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15854. Make some parameters configurable for SlowDiskTracker and… #2718

Merged
merged 1 commit into from Mar 1, 2021
Merged

HDFS-15854. Make some parameters configurable for SlowDiskTracker and… #2718

merged 1 commit into from Mar 1, 2021

Conversation

tomscut
Copy link
Contributor

@tomscut tomscut commented Feb 23, 2021

JIRA: https://issues.apache.org/jira/browse/HDFS-15854

Make some parameters configurable for SlowDiskTracker and SlowPeerTracker. Related to the previous issue: HDFS-15814.

@tomscut
Copy link
Contributor Author

tomscut commented Mar 1, 2021

Hi @arp7 @dineshchitlangia , Could you please help to review the code. Thank you.
It is related to a previous issue: https://issues.apache.org/jira/browse/HDFS-15814.

Those failed unit tests were unrelated to the change.
Failed junit tests:
hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
hadoop.hdfs.server.namenode.TestNamenodeCapacityReport

arp7
arp7 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arp7
Copy link
Contributor

arp7 commented Mar 1, 2021

Hi @tomscut, I don't see where the Jenkins checks have run successfully. Can you point me to the report?

@tomscut
Copy link
Contributor Author

tomscut commented Mar 1, 2021 •
edited

Hi @tomscut, I don't see where the Jenkins checks have run successfully. Can you point me to the report?

Hi @arp7 , thanks for your review.

I saw pre-check result from: https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-2718/1/pipeline.
image

And I am a little confused why there is no output of pre-check results. Can we trigger a pre-check again?

@arp7
Copy link
Contributor

arp7 commented Mar 1, 2021

Okay I see, the only failure is the two unrelated unit tests. I will merge this shortly.

@arp7 arp7 merged commit 32353eb into apache:trunk Mar 1, 2021
@tomscut
Copy link
Contributor Author

tomscut commented Mar 1, 2021

Okay I see, the only failure is the two unrelated unit tests. I will merge this shortly.

Thank you very much.

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@tomscut
HDFS-15854. Make some parameters configurable for SlowDiskTracker and…
2ff92b8 
… SlowPeerTracker (apache#2718)

Authored-by: tomscut <litao@bigo.sg>
tasanuma pushed a commit that referenced this pull request Feb 25, 2022
@tomscut @tasanuma
HDFS-15854. Make some parameters configurable for SlowDiskTracker and…
5601d08 
… SlowPeerTracker (#2718)

Authored-by: tomscut <litao@bigo.sg>
(cherry picked from commit 32353eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arp7 arp7 arp7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tomscut @arp7