HDFS-15892. Add metric for editPendingQ in FSEditLogAsync #2770

tomscut · 2021-03-12T16:39:48Z

To monitor editPendingQ in FSEditLogAsync, we add a metric and print log when the queue is full.

hadoop-yetus · 2021-03-12T22:05:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 2s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 2s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 14s		trunk passed
+1 💚	compile	1m 21s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 13s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 1s		trunk passed
+1 💚	mvnsite	1m 19s		trunk passed
+1 💚	javadoc	0m 54s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 24s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	3m 14s		trunk passed
+1 💚	shadedclient	18m 40s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 17s		the patch passed
+1 💚	compile	1m 8s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 55s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 52 unchanged - 0 fixed = 53 total (was 52)
+1 💚	mvnsite	1m 14s		the patch passed
+1 💚	javadoc	0m 46s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 18s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	3m 19s		the patch passed
+1 💚	shadedclient	18m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	221m 54s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		324m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2770/1/artifact/out/Dockerfile
GITHUB PR	#2770
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 8696293a4a14 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a9ce11c`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2770/1/testReport/
Max. process+thread count	2193 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2770/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-03-17T11:19:33Z

Hi @daryn-sharp @umamaheswararao , could you please help review the code?

tomscut · 2021-03-29T11:31:54Z

Hi @tasanuma @dineshchitlangia , could you please help review the code?

tasanuma

@tomscut Thanks for working on this, and sorry for the late reply. I left some minor comments.

...adoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java

hadoop-yetus · 2021-04-01T22:40:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	markdownlint	0m 0s		markdownlint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 12s		trunk passed
+1 💚	compile	21m 29s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	18m 55s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	3m 52s		trunk passed
+1 💚	mvnsite	3m 5s		trunk passed
+1 💚	javadoc	2m 6s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	3m 19s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	5m 47s		trunk passed
+1 💚	shadedclient	17m 12s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s		the patch passed
+1 💚	compile	21m 3s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	21m 3s		the patch passed
+1 💚	compile	19m 33s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	19m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 14s	/results-checkstyle-root.txt	root: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53)
+1 💚	mvnsite	3m 15s		the patch passed
+1 💚	javadoc	2m 11s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	3m 21s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	6m 19s		the patch passed
+1 💚	shadedclient	18m 2s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 43s		hadoop-common in the patch passed.
-1 ❌	unit	230m 45s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 8s		The patch does not generate ASF License warnings.
		441m 3s

Reason	Tests
Failed junit tests	hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
	hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
	hadoop.hdfs.qjournal.server.TestJournalNodeSync
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.datanode.TestBlockRecovery

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2770/2/artifact/out/Dockerfile
GITHUB PR	#2770
Optional Tests	dupname asflicense mvnsite codespell markdownlint compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle
uname	Linux ff06d0455a93 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f7e7a91`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2770/2/testReport/
Max. process+thread count	2974 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2770/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-04-02T01:07:00Z

Those failed unit tests are unrelated to the change, they work fine locally.

tasanuma

Thanks for updating the PR, @tomscut.
The checkstyle issue is the same as other metrics. +1.

tomscut · 2021-04-02T01:23:12Z

Thanks for updating the PR, @tomscut.
The checkstyle issue is the same as other metrics. +1.

Thanks @tasanuma for your review.

tasanuma · 2021-04-02T01:34:02Z

Merged it. Thanks for your contribution, @tomscut!

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit 4bd0412)

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

fs edits log

a9ce11c

tasanuma reviewed Apr 1, 2021

View reviewed changes

...adoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java Outdated Show resolved Hide resolved

update metric name, add description for the metric

f7e7a91

tasanuma approved these changes Apr 2, 2021

View reviewed changes

tasanuma merged commit 4bd0412 into apache:trunk Apr 2, 2021

tasanuma pushed a commit that referenced this pull request Apr 2, 2021

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync (#2770)

62937d1

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit 4bd0412)

tasanuma pushed a commit that referenced this pull request Apr 2, 2021

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync (#2770)

d566e4e

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit 4bd0412)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync (apache#2770)

5bf9179

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync #2770

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync #2770

tomscut commented Mar 12, 2021

hadoop-yetus commented Mar 12, 2021

tomscut commented Mar 17, 2021

tomscut commented Mar 29, 2021

tasanuma left a comment

hadoop-yetus commented Apr 1, 2021

tomscut commented Apr 2, 2021

tasanuma left a comment

tomscut commented Apr 2, 2021

tasanuma commented Apr 2, 2021

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync #2770

HDFS-15892. Add metric for editPendingQ in FSEditLogAsync #2770

Conversation

tomscut commented Mar 12, 2021

hadoop-yetus commented Mar 12, 2021

tomscut commented Mar 17, 2021

tomscut commented Mar 29, 2021

tasanuma left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Apr 1, 2021

tomscut commented Apr 2, 2021

tasanuma left a comment

Choose a reason for hiding this comment

tomscut commented Apr 2, 2021

tasanuma commented Apr 2, 2021