HADOOP-17619. Fix DelegationTokenRenewer#updateRenewalTime java doc error. #2846

zhuqi-lucas · 2021-03-31T14:43:32Z

https://issues.apache.org/jira/browse/HADOOP-17619

hadoop-yetus · 2021-03-31T17:45:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 53s		trunk passed
+1 💚	compile	20m 31s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 54s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 4s		trunk passed
+1 💚	mvnsite	1m 31s		trunk passed
+1 💚	javadoc	1m 3s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 37s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 18s		trunk passed
+1 💚	shadedclient	15m 29s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s		the patch passed
+1 💚	compile	19m 51s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	19m 51s		the patch passed
+1 💚	compile	18m 2s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	18m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 30s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 33s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 28s		the patch passed
+1 💚	shadedclient	15m 39s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 12s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		175m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2846/1/artifact/out/Dockerfile
GITHUB PR	#2846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 1c5b54a35b5b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / c806eec7a8076d80de8c0fb16303e4fae4d3f4bc
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2846/1/testReport/
Max. process+thread count	2135 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2846/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

zhuqi-lucas · 2021-04-01T02:37:51Z

@umamaheswararao @aajisaka @ayushtkn
Could you help review this?
It's a error java doc for updateRenewalTime.
Thanks.

ayushtkn

Thanx @qizhu-lucas for the fix, give a check to the javadoc description once.

ayushtkn · 2021-04-03T21:56:22Z

...-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java

@@ -107,7 +107,7 @@ public boolean equals(final Object that) {
     * Set a new time for the renewal.
     * It can only be called when the action is not in the queue or any
     * collection because the hashCode may change
-     * @param newTime the new time
+     * @param delay the renew cycle


Shouldn't this be.
the renewal time
rather than the renew cycle

Thanks @ayushtkn for good suggestion, it's more reasonable.
Updated this in latest PR.

…rror.

hadoop-yetus · 2021-04-04T08:28:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 38s		trunk passed
+1 💚	compile	20m 37s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 57s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 31s		trunk passed
+1 💚	javadoc	1m 4s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 34s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 22s		trunk passed
+1 💚	shadedclient	15m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 51s		the patch passed
+1 💚	compile	20m 24s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 24s		the patch passed
+1 💚	compile	17m 57s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	17m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 28s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 37s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	spotbugs	2m 29s		the patch passed
+1 💚	shadedclient	15m 31s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	17m 25s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 56s		The patch does not generate ASF License warnings.
		176m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2846/2/artifact/out/Dockerfile
GITHUB PR	#2846
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 5fc4cda87a23 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `49ead2d`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2846/2/testReport/
Max. process+thread count	2359 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2846/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn

+1

…rror. (apache#2846). Contributed by Qi Zhu. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

ayushtkn reviewed Apr 3, 2021

View reviewed changes

HADOOP-17619: Fix DelegationTokenRenewer#updateRenewalTime java doc e…

49ead2d

…rror.

zhuqi-lucas force-pushed the HADOOP-17619 branch from c806eec to 49ead2d Compare April 4, 2021 05:30

ayushtkn changed the title ~~HADOOP-17619: Fix DelegationTokenRenewer#updateRenewalTime java doc e…~~ HADOOP-17619. Fix DelegationTokenRenewer#updateRenewalTime java doc error. Apr 4, 2021

ayushtkn approved these changes Apr 4, 2021

View reviewed changes

ayushtkn merged commit 5eaa1b7 into apache:trunk Apr 4, 2021

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17619: Fix DelegationTokenRenewer#updateRenewalTime java doc e…

99a34b4

…rror. (apache#2846). Contributed by Qi Zhu. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-17619. Fix DelegationTokenRenewer#updateRenewalTime java doc error. #2846

HADOOP-17619. Fix DelegationTokenRenewer#updateRenewalTime java doc error. #2846

zhuqi-lucas commented Mar 31, 2021 •

edited by ayushtkn

Loading

hadoop-yetus commented Mar 31, 2021

zhuqi-lucas commented Apr 1, 2021 •

edited

Loading

ayushtkn left a comment

ayushtkn Apr 3, 2021

zhuqi-lucas Apr 4, 2021

hadoop-yetus commented Apr 4, 2021

ayushtkn left a comment

HADOOP-17619. Fix DelegationTokenRenewer#updateRenewalTime java doc error. #2846

HADOOP-17619. Fix DelegationTokenRenewer#updateRenewalTime java doc error. #2846

Conversation

zhuqi-lucas commented Mar 31, 2021 • edited by ayushtkn Loading

hadoop-yetus commented Mar 31, 2021

zhuqi-lucas commented Apr 1, 2021 • edited Loading

ayushtkn left a comment

Choose a reason for hiding this comment

ayushtkn Apr 3, 2021

Choose a reason for hiding this comment

zhuqi-lucas Apr 4, 2021

Choose a reason for hiding this comment

hadoop-yetus commented Apr 4, 2021

ayushtkn left a comment

Choose a reason for hiding this comment

zhuqi-lucas commented Mar 31, 2021 •

edited by ayushtkn

Loading

zhuqi-lucas commented Apr 1, 2021 •

edited

Loading