-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17756. Increase precommit job timeout from 20 hours to 24 hours. #3090
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (non-binding). Just a thought, before committing, do we want to update just one line in hadoop-main pom.xml to trigger full run? Based on that, we might come to know of new timeout value if 24 hr is also not sufficient.
@virajjasani Thanks for your review. Agreed with you. Updated the PR. |
💔 -1 overall
This message was automatically generated. |
This reverts commit 87a7090.
The last QA time is 21 hours. I think 24 hours for timeout is appropriate. |
Sounds great, 24 hr should be good enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
💔 -1 overall
This message was automatically generated. |
Thanks for your reviews, @aajisaka and @virajjasani. |
…s. (apache#3090) Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org>
JIRA: HADOOP-17756