HADOOP-17788. Replace IOUtils#closeQuietly usages by Hadoop's own utility #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,7 +322,7 @@ public NewShmInfo createNewMemorySegment(String clientName, | |||
| shm = new RegisteredShm(clientName, shmId, fis, this); | |||
| } finally { | |||
| if (shm == null) { | |||
| IOUtils.closeQuietly(fis); | |||
| IOUtils.cleanupWithLogger(null, fis); | |||
There was a problem hiding this comment.
why not use closeStream(fis)?
There was a problem hiding this comment.
Sounds good, closeStream() is also accessible and does the same so it's cleaner than passing null for each. Let me make this change.
| @@ -105,7 +105,7 @@ public MappableBlock load(long length, FileInputStream blockIn, | |||
| + ", [cached path={}, address={}, length={}]", key, filePath, | |||
| region.getAddress(), length); | |||
| } finally { | |||
| IOUtils.closeQuietly(blockChannel); | |||
| org.apache.hadoop.io.IOUtils.cleanupWithLogger(null, blockChannel); | |||
There was a problem hiding this comment.
any reason not to import?
|
To fix deprecation warning, I perfer using try-with-resources rather than replacing with our internal replacement. |
|
@aajisaka it seems only few places can live with |
virajjasani
force-pushed
the
HADOOP-17788-trunk
branch
from
104c035
to
eec10e2
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@aajisaka @steveloughran I have addressed review comments. Could you please take a look? |
Mixed feelings there. I went through a lot of grief in HADOOP-16998/#2073 related to exceptions being raised in try with resources while a prior exception has been raised. The JVM will attach any ex raised in the resource closed to the initial ex via addSuppressed(), but if somehow it's the same exception you get an IllegalArgumentException with all stack traces lost. so, good
bad
ugly
|
|
💔 -1 overall
This message was automatically generated. |
|
Thanks for the review @steveloughran and thanks for the example of how JDK can produce |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
approved these changes
Jul 7, 2021
yeah, stupid thing for them to do. wasb was being clever about caching and rethrowing the same exception in close() as in the read(), and some code using it above hadoop was failing. what a pain. |
|
Merged it. Thanks for your contribution, @virajjasani. Thanks for your reviews and your variable comments, @steveloughran and @aajisaka. |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…lity (apache#3171) Reviewed-by: Steve Loughran <stevel@apache.org> Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOUtils#closeQuietly is deprecated since 2.6 release of commons-io without any replacement. Since we already have good replacement available in Hadoop's own IOUtils, we should use it.