HDFS-16305.Record the remote NameNode address when the rolling log is triggered. #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
It looks like jenkins failed, there are some exceptions. It doesn't seem to have much to do with the pr I submitted. |
virajjasani
reviewed
Nov 9, 2021
| @@ -413,6 +413,8 @@ private boolean tooLongSinceLastLoad() { | |||
| return new MultipleNameNodeProxy<Void>() { | |||
| @Override | |||
| protected Void doWork() throws IOException { | |||
| LOG.info("Triggering log scrolling to the remote NameNode, " + | |||
There was a problem hiding this comment.
replace log scrolling with log rolling?
There was a problem hiding this comment.
The log already exists on line 427: LOG.info("Triggering log roll on remote NameNode");.
Should we remove the original log?
There was a problem hiding this comment.
Thanks @virajjasani for the comment and review.
Yes, I agree with @tomscut's opinion. There is no need to record logs repeatedly.
jianghuazhu
force-pushed
the
HDFS-16305
branch
from
09d0cea
to
e3259be
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Can you help review this pr again, @virajjasani @tomscut . |
|
Thank you very much. @virajjasani @tomscut |
ferhui
approved these changes
Nov 12, 2021
|
@jianghuazhu Thanks for contribution. @ayushtkn @virajjasani @tomscut Thanks for review! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When StandbyNN triggers the rolling log, it sends a request to the remote NameNode. But there is no way to know the specific information of the NameNode.
Here are some log information:
We can try to record the specific address.
This is the purpose of this pr.
How was this patch tested?
Some log information has been changed here, which is not very stressful for testing.