Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18040. Use maven.test.failure.ignore instead of ignoreTestFailure #3774

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Dec 9, 2021

Description of PR

HADOOP-18040
Use maven.test.failure.ignore instead of using a new variable ignoreTestFailure.

How was this patch tested?

  1. Create a unit test to fail.
  2. The test failure is ignored as expected.
  3. Add -Dmaven.test.failure.ignore=false from command line. Verify that the test failure is not ignored.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • n/a Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • n/a If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks, @aajisaka.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 13m 23s Maven dependency ordering for branch
+1 💚 mvninstall 25m 54s trunk passed
+1 💚 compile 23m 52s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 20m 13s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 mvnsite 6m 45s trunk passed
+1 💚 javadoc 5m 21s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 6m 14s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 shadedclient 124m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 4m 19s the patch passed
+1 💚 compile 22m 57s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 22m 57s the patch passed
+1 💚 compile 20m 9s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 20m 9s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 6m 44s the patch passed
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
+1 💚 javadoc 5m 20s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 6m 20s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 shadedclient 35m 58s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 27s hadoop-project in the patch passed.
-1 ❌ unit 17m 17s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 unit 3m 36s hadoop-kms in the patch passed.
+1 💚 unit 1m 15s hadoop-registry in the patch passed.
-1 ❌ unit 313m 20s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 7m 49s hadoop-hdfs-httpfs in the patch passed.
+1 💚 unit 38m 7s hadoop-distcp in the patch passed.
+1 💚 unit 20m 54s hadoop-federation-balance in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
622m 11s
Reason Tests
Failed junit tests hadoop.ipc.TestIPC
hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3774/1/artifact/out/Dockerfile
GITHUB PR #3774
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux 5be33b4a7b27 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3f67b64
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3774/1/testReport/
Max. process+thread count 3134 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-tools/hadoop-distcp hadoop-tools/hadoop-federation-balance U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3774/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

+1 (non-binding), better approach.

@aajisaka aajisaka merged commit 9b9e2ef into apache:trunk Dec 9, 2021
@aajisaka aajisaka deleted the HADOOP-18040 branch December 9, 2021 16:36
@aajisaka
Copy link
Member Author

aajisaka commented Dec 9, 2021

Merged. Thank you @iwasakims and @virajjasani for your review.

aajisaka added a commit that referenced this pull request Dec 9, 2021
…ure (#3774)

Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
(cherry picked from commit 9b9e2ef)

 Conflicts:
	hadoop-tools/hadoop-federation-balance/pom.xml
aajisaka added a commit that referenced this pull request Dec 9, 2021
…ure (#3774)

Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
(cherry picked from commit 9b9e2ef)

 Conflicts:
	hadoop-tools/hadoop-federation-balance/pom.xml

(cherry picked from commit 35c5c6b)

 Conflicts:
	hadoop-common-project/hadoop-registry/pom.xml
aajisaka added a commit that referenced this pull request Dec 9, 2021
…ure (#3774)

Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
(cherry picked from commit 9b9e2ef)

 Conflicts:
	hadoop-tools/hadoop-federation-balance/pom.xml

(cherry picked from commit 35c5c6b)

 Conflicts:
	hadoop-common-project/hadoop-registry/pom.xml

(cherry picked from commit 94ca965)
ashutoshcipher pushed a commit to ashutoshcipher/hadoop that referenced this pull request Dec 22, 2021
…ure (apache#3774)

Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
sunchao pushed a commit that referenced this pull request Jan 4, 2022
…ure (#3774)

Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
(cherry picked from commit 9b9e2ef)

 Conflicts:
	hadoop-tools/hadoop-federation-balance/pom.xml
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
…ure (apache#3774)

Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants