-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18040. Use maven.test.failure.ignore instead of ignoreTestFailure #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
iwasakims
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks, @aajisaka.
💔 -1 overall
This message was automatically generated. |
+1 (non-binding), better approach. |
Merged. Thank you @iwasakims and @virajjasani for your review. |
ashutoshcipher
pushed a commit
to ashutoshcipher/hadoop
that referenced
this pull request
Dec 22, 2021
…ure (apache#3774) Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ure (apache#3774) Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-18040
Use
maven.test.failure.ignore
instead of using a new variableignoreTestFailure
.How was this patch tested?
-Dmaven.test.failure.ignore=false
from command line. Verify that the test failure is not ignored.For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?