-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11045. ATSv2 storage monitor fails to read from hbase cluster #3796
Conversation
@aajisaka @jojochuang @tasanuma Could you please take a look? |
💔 -1 overall
This message was automatically generated. |
Javadoc warnings are not relevant to this PR. They can be taken up in a separate task to fix existing checkstyle issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for reporting the bug and providing the fix!
Will merge later today |
@virajjasani , I tried porting your changes and I can still see yarn resourcemanager having the same issue for me. |
@minni31 have you also done changes in After porting the changes, building the tarball ( |
Yes @virajjasani, it fails, even after changes in bin/yarn |
With the changes on this PR, it works for me. For me, timeline reader works well with this patch. Without this patch, the Exception is thrown as mentioned on the PR description. |
Just pushed an addendum to make the same Yarn classpath change for Windows OS. |
I had an offline sync with @minni31 FYI @jojochuang |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Thanks @virajjasani |
+1 based on the good faith of Viraj. Merging it now. |
Description of PR
HBase compatible guava dependency is bit messed up i.e. timelineservice-hbase modules are still being built with Hadoop's guava version (defined in hadoop-project) and this creates issues with HBaseStorageMonitor reading records from hbase cluster:
TimelineReaderServer logs after fixing the issue:
How was this patch tested?
For code changes: