Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18150. Fix ITestAuditManagerDisabled test in S3A. #4044

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

mehakmeet
Copy link
Contributor

Description of PR

Fix ITestAuditManagerDisabled test which verifies that auditing is disabled by default. In HADOOP-18091 we made it enabled by default.

How was this patch tested?

Region: ap-south-1.
Command: mvn clean verify -Dparallel-tests -DtestsThreadCount=4 -Dscale

[INFO] Running org.apache.hadoop.fs.s3a.audit.ITestAuditManagerDisabled
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.275 s - in org.apache.hadoop.fs.s3a.audit.ITestAuditManagerDisabled

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@mehakmeet
Copy link
Contributor Author

CC; @mukund-thakur @steveloughran

Copy link
Contributor

@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1;
Reran the failed test.

@steveloughran steveloughran merged commit 6995374 into apache:trunk Mar 3, 2022
@steveloughran
Copy link
Contributor

merged. worried that my test coverage process isn't complete enough right now...

asfgit pushed a commit that referenced this pull request Mar 3, 2022
Contributed by Mehakmeet Singh

Change-Id: I25c10844e4ad64b1fd7af9a02018220a611c85e0
@apache apache deleted a comment from hadoop-yetus May 4, 2022
@apache apache deleted a comment from hadoop-yetus May 4, 2022
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…pache#4044)

Contributed by Mehakmeet Singh

Change-Id: I25c10844e4ad64b1fd7af9a02018220a611c85e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants