Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18155. Refactor tests in TestFileUtil (#4053) #4063

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

jojochuang
Copy link
Contributor

(cherry picked from commit d0fa9b5)

Conflicts:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 9m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 33m 39s branch-3.3 passed
+1 💚 compile 18m 16s branch-3.3 passed
+1 💚 checkstyle 0m 48s branch-3.3 passed
+1 💚 mvnsite 1m 31s branch-3.3 passed
+1 💚 javadoc 1m 34s branch-3.3 passed
+1 💚 spotbugs 2m 21s branch-3.3 passed
+1 💚 shadedclient 26m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 56s the patch passed
+1 💚 compile 17m 16s the patch passed
+1 💚 javac 17m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 46s hadoop-common-project/hadoop-common: The patch generated 0 new + 60 unchanged - 15 fixed = 60 total (was 75)
+1 💚 mvnsite 1m 30s the patch passed
+1 💚 javadoc 1m 31s the patch passed
+1 💚 spotbugs 2m 32s the patch passed
+1 💚 shadedclient 26m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 16m 56s hadoop-common in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
162m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4063/1/artifact/out/Dockerfile
GITHUB PR #4063
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 973e88b52056 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 2948e6f
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4063/1/testReport/
Max. process+thread count 1236 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4063/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@GauthamBanasandra GauthamBanasandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwasakims iwasakims merged commit 743db6e into apache:branch-3.3 Mar 14, 2022
iwasakims pushed a commit that referenced this pull request Mar 14, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
(cherry picked from commit 743db6e)
iwasakims pushed a commit that referenced this pull request Mar 14, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
(cherry picked from commit 743db6e)
steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Apr 5, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Change-Id: I2bba28c56dd08da315856066b58b1778b67bfb45
Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Apr 12, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Change-Id: I2bba28c56dd08da315856066b58b1778b67bfb45
Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
asfgit pushed a commit that referenced this pull request Apr 13, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Change-Id: I2bba28c56dd08da315856066b58b1778b67bfb45
Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
asfgit pushed a commit that referenced this pull request Apr 14, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Change-Id: I2bba28c56dd08da315856066b58b1778b67bfb45
Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
iwasakims pushed a commit that referenced this pull request Apr 14, 2022
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>
(cherry picked from commit 743db6e)
(cherry picked from commit 826d13a)

Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
jojochuang added a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
(cherry picked from commit d0fa9b5)

 Conflicts:
	hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java
	hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Co-authored-by: Gautham B A <gautham.bangalore@gmail.com>

(cherry picked from 743db6e)

Change-Id: Ia73345b65747af8d7f9a3b3956cb4d6429517415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants