-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18160 Avoid shading wildfly.openssl runtime dependency #4074
HADOOP-18160 Avoid shading wildfly.openssl runtime dependency #4074
Conversation
thanks. will have to raise this with on the hadoop common list to discuss what to do here. |
raised on the list...if nobody objects i will merge (remind me if I don't) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. nobody said no, and we do the same for other optional classes.
Contributed by André Fonseca. Change-Id: I198c66b58c0e05c1752ad9d6a50fe2f2932f61d5
ok, merged in to branch-3.3 and trunk. thank you! |
Contributed by André Fonseca. Change-Id: I198c66b58c0e05c1752ad9d6a50fe2f2932f61d5
…#4074) Contributed by André Fonseca.
Description of PR
org.wildfly.openssl
is a runtime library and its references are being shaded on Hadoop, breaking the integration with other frameworks like Spark, whenever the "fs.s3a.ssl.channel.mode" is set to "openssl". The error produced in this situation is:This PR aims to exclude
org.wildfly.openssl
from the shade, keeping the original namespace to be referenced whenever this runtime dependency is added to the classpath.How was this patch tested?
Used the patched jar on a Spark 3.2.1 application which now correctly references the
org.wildfly.openssl
dependency added to the classpath.For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?