HDFS-16534. Split FsDatasetImpl from block pool locks to volume grain locks. #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
MingXiangLi
force-pushed
the
trunk-support-volume-lock
branch
from
8e2e66f
to
315565e
Compare
MingXiangLi
changed the title
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Apr 10, 2022
...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
Outdated
Show resolved
Hide resolved
| @@ -629,6 +634,9 @@ public void removeVolumes( | |||
| synchronized (this) { | |||
| for (String storageUuid : storageToRemove) { | |||
| storageMap.remove(storageUuid); | |||
| for (String bp : volumeMap.getBlockPoolList()) { | |||
There was a problem hiding this comment.
do we need to synchronized this segment? IMO, lock remove is thread safe here, right?
There was a problem hiding this comment.
It may add lot of locks. All method related add/remove locks is get synchronized first.
...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
Show resolved
Hide resolved
...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
Show resolved
Hide resolved
...-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
Show resolved
Hide resolved
| .getNumBytes()); | ||
| FsVolumeImpl v = (FsVolumeImpl) ref.getVolume(); | ||
| ReplicaInPipeline newReplicaInfo; | ||
| FsVolumeReference ref = volumes.getNextVolume(storageType, storageId, b |
There was a problem hiding this comment.
Not sure if this is thread safe without any ReadWriteLock.
There was a problem hiding this comment.
volumes. getNextVolume() is thread safe, and no need protected by dataset lock.
|
Please fix checkstyle as Yetus suggest /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
MingXiangLi
force-pushed
the
trunk-support-volume-lock
branch
from
315565e
to
6f4ffd6
Compare
|
1、some method is not good change to volume lock, and if split to volume lock it have to get locks and release locks sequence(like acquire lock1, lock2, lock3, release lock 3 lock2 lock1).So just acquire block pool lock is enough. |
|
🎊 +1 overall
This message was automatically generated. |
|
LGTM +1 from my side. I would like to check into trunk if no furthermore feedback while 5 work days later.
I would like to clarify this explanation. This improvement only change part of methods from block pool level lock to volume level lock rather all. Because, Thanks @MingXiangLi for your works. |
Hexiaoqiao
approved these changes
Apr 13, 2022
asfgit
pushed a commit
that referenced
this pull request
Apr 17, 2022
… locks. (#4141) Contributed by limingxiang. Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
|
Committed to trunk. Thanks @MingXiangLi for your contributions. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… locks. (apache#4141) Contributed by limingxiang. Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-15382 have split lock to block pool grain and do some prepare.This pr is the last part of volume lock.