-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-10303. Fixing rest api example, status code error and other typos in ResourceManagerRest.md #4221
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the other typo of ResourceManagerRest.md
together? Thank you.
@tomscut - Thanks for the review. I have fixed the other typo as part of this CR. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Can you help fix several typos in this file at the same time?
Such as ReservationRequeust
, iniital
, applicaiton
, capabilites
, setions
, paramters
. Thank you very much.
@tomscut - Addressed your comments and fixed the other typos as well. Thanks. |
| credentials | object | The credentials required for your application to run, described below | | ||
| application-acls | objec | ACLs for your application; the key can be "VIEW\_APP" or "MODIFY\_APP", the value is the list of users with the permissions | | ||
| Item | Data Type | Description | | ||
|:---- |:---- |:------------------------------------------------------------------------------------------------------------------------------------| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep it as it is here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Seems like IntelliJ did some mess up there.
| application-acls | objec | ACLs for your application; the key can be "VIEW\_APP" or "MODIFY\_APP", the value is the list of users with the permissions | | ||
| Item | Data Type | Description | | ||
|:---- |:---- |:------------------------------------------------------------------------------------------------------------------------------------| | ||
| local-resources | object | Object describing the resources that need to be localized, described below | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep it as it is here. Other changes looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Seems like IntelliJ did some mess up there.
Thank you. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
🎊 +1 overall
This message was automatically generated. |
Thanks @ashutoshcipher for your contribution. Thanks @goiri for your review. |
…s in ResourceManagerRest.md (apache#4221)
Description of PR
Fixing rest api example, status code error and other typos in ResourceManagerRest.md