Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-10303. Fixing rest api example, status code error and other typos in ResourceManagerRest.md #4221

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

ashutoshcipher
Copy link
Contributor

@ashutoshcipher ashutoshcipher commented Apr 22, 2022

Description of PR

Fixing rest api example, status code error and other typos in ResourceManagerRest.md

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 18m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 6s trunk passed
+1 💚 mvnsite 0m 46s trunk passed
+1 💚 shadedclient 59m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 23s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 27s the patch passed
+1 💚 shadedclient 19m 36s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
100m 30s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/1/artifact/out/Dockerfile
GITHUB PR #4221
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux c91edf7ee835 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c1abce0
Max. process+thread count 719 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@tomscut tomscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the other typo of ResourceManagerRest.md together? Thank you.

@ashutoshcipher ashutoshcipher changed the title YARN-10303. Fixing rest api example in ResourceManagerRest.md YARN-10303. Fixing rest api example and status code error in ResourceManagerRest.md Apr 24, 2022
@ashutoshcipher
Copy link
Contributor Author

ashutoshcipher commented Apr 24, 2022

Can you fix the other typo of ResourceManagerRest.md together? Thank you.

@tomscut - Thanks for the review. I have fixed the other typo as part of this CR.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 41m 43s trunk passed
+1 💚 mvnsite 0m 38s trunk passed
+1 💚 shadedclient 66m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 21s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 26s the patch passed
+1 💚 shadedclient 25m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 44s The patch does not generate ASF License warnings.
95m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/2/artifact/out/Dockerfile
GITHUB PR #4221
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux fc22bf63b3ba 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2f4f71c
Max. process+thread count 569 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@tomscut tomscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Can you help fix several typos in this file at the same time?
Such as ReservationRequeust, iniital, applicaiton, capabilites, setions, paramters. Thank you very much.

@ashutoshcipher
Copy link
Contributor Author

@tomscut - Addressed your comments and fixed the other typos as well. Thanks.

@ashutoshcipher ashutoshcipher changed the title YARN-10303. Fixing rest api example and status code error in ResourceManagerRest.md YARN-10303. Fixing rest api example, status code error and other typos in ResourceManagerRest.md Apr 25, 2022
| credentials | object | The credentials required for your application to run, described below |
| application-acls | objec | ACLs for your application; the key can be "VIEW\_APP" or "MODIFY\_APP", the value is the list of users with the permissions |
| Item | Data Type | Description |
|:---- |:---- |:------------------------------------------------------------------------------------------------------------------------------------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep it as it is here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Seems like IntelliJ did some mess up there.

| application-acls | objec | ACLs for your application; the key can be "VIEW\_APP" or "MODIFY\_APP", the value is the list of users with the permissions |
| Item | Data Type | Description |
|:---- |:---- |:------------------------------------------------------------------------------------------------------------------------------------|
| local-resources | object | Object describing the resources that need to be localized, described below |
Copy link
Contributor

@tomscut tomscut Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep it as it is here. Other changes looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Seems like IntelliJ did some mess up there.

@tomscut
Copy link
Contributor

tomscut commented Apr 25, 2022

@tomscut - Addressed your comments and fixed the other typos as well. Thanks.

Thank you.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 31s trunk passed
+1 💚 mvnsite 0m 48s trunk passed
+1 💚 shadedclient 60m 6s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 25s the patch passed
+1 💚 shadedclient 19m 31s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
83m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/3/artifact/out/Dockerfile
GITHUB PR #4221
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux d7da902a2d14 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 4a495a8
Max. process+thread count 545 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/3/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@tomscut tomscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 30s trunk passed
+1 💚 mvnsite 0m 39s trunk passed
+1 💚 shadedclient 66m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 23s the patch passed
+1 💚 shadedclient 22m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
92m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/4/artifact/out/Dockerfile
GITHUB PR #4221
Optional Tests dupname asflicense mvnsite codespell markdownlint
uname Linux c9a022b4ba5a 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / aab8a75
Max. process+thread count 525 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4221/4/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomscut
Copy link
Contributor

tomscut commented Apr 26, 2022

Thanks @ashutoshcipher for your contribution. Thanks @goiri for your review.

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants