-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18219. Revert "HADOOP-15983. Use jersey-json that is built to use jackson2 (#3988)" #4253
Conversation
Hi @pjfanning, @aajisaka, @steveloughran, This commit has broken the shadedclient tests on Debian 10 - 6318708. The last known good commit where shadedclient tests ran successfully is aebd55f. Here are the steps that I followed -
$ docker build -t hadoop-builder-debian-10 -f .\dev-support\docker\Dockerfile_debian_10 .\dev-support\docker\
$ docker run -it hadoop-builder-debian-10 bash
$ git clone https://github.com/apache/hadoop.git
$ cd hadoop
$ git bisect start
$ git bisect good aebd55f7883c6b12afe5faeb776ab0e0b83420da
$ git bisect bad 63187083cc3b9bb1c1e90e692e271958561f9cc8
$ /usr/bin/mvn verify -fae -am -pl hadoop-client-modules/hadoop-client-check-invariants -pl hadoop-client-modules/hadoop-client-check-test-invariants -pl hadoop-client-modules/hadoop-client-integration-tests -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true |
If you think reverting the changes altogether is best, then feel free to do this. The PR you are reverting had pom changes for hadoop-client-minicluster including exclusions of the jaxb transitive dependencies - probably due to dependency convergence errors. Adding explicit dependencies to the jaxb jars in hadoop-client-minicluster might fix the issue. I'm currently travelling and am not in an ideal position to try any changes myself (apologies). |
Thanks @GauthamBanasandra for your report and thanks @pjfanning for your comment. I opened #4254 to fix the exclusion. Would you check the PR? |
💔 -1 overall
This message was automatically generated. |
Abandoning this PR since the issue was fixed by #4254. |
Description of PR
This reverts commit 6318708. This commit seems to break the shadedclient tests on Debian 10 - #4245 (comment).
How was this patch tested?
In progress.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?