HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo… #4340

HanleyYang · 2022-05-22T02:33:19Z

Description of PR

WebHdfsFileSystem is not syncable, it should not fail the test.
https://issues.apache.org/jira/browse/HDFS-15878

How was this patch tested?

Updated existing unit tests.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…ntractCreateTest#testSyncable

hadoop-yetus · 2022-05-22T06:12:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 35s		trunk passed
+1 💚	compile	23m 36s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 58s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 34s		trunk passed
+1 💚	mvnsite	1m 59s		trunk passed
+1 💚	javadoc	1m 34s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 8s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 11s		trunk passed
+1 💚	shadedclient	23m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 6s		the patch passed
+1 💚	compile	23m 13s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	23m 13s		the patch passed
+1 💚	compile	21m 48s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 35s	/results-checkstyle-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 💚	mvnsite	2m 7s		the patch passed
+1 💚	javadoc	1m 40s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 16s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 1s		the patch passed
+1 💚	shadedclient	23m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 27s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 22s		The patch does not generate ASF License warnings.
		217m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4340/1/artifact/out/Dockerfile
GITHUB PR	#4340
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 132123a79039 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e16b3ad`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4340/1/testReport/
Max. process+thread count	2385 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4340/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

...ct/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java

hadoop-yetus · 2022-05-24T06:04:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 11s		trunk passed
+1 💚	compile	23m 48s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 54s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 43s		trunk passed
+1 💚	mvnsite	2m 13s		trunk passed
+1 💚	javadoc	1m 40s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 10s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 5s		trunk passed
+1 💚	shadedclient	23m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s		the patch passed
+1 💚	compile	22m 59s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 59s		the patch passed
+1 💚	compile	21m 46s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 46s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 35s		hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚	mvnsite	2m 5s		the patch passed
+1 💚	javadoc	1m 30s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 21s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 6s		the patch passed
+1 💚	shadedclient	23m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 18s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 25s		The patch does not generate ASF License warnings.
		221m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4340/2/artifact/out/Dockerfile
GITHUB PR	#4340
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux ba989b951e01 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `44f3349`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4340/2/testReport/
Max. process+thread count	3158 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4340/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn

The said test didn't run as part of Jenkins build since the change was in Hadoop-Common not is Hadoop-RBF,
Tried the test locally and no issues there.

Changes LGTM

ayushtkn · 2022-05-28T04:26:26Z

Merged. Thanx @HanleyYang for the contribution and @goiri for the review!!!

…pache#4340). Contributed by Hanley Yang. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo…

e16b3ad

…ntractCreateTest#testSyncable

goiri approved these changes May 23, 2022

View reviewed changes

goiri reviewed May 23, 2022

View reviewed changes

...ct/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java Outdated Show resolved Hide resolved

HDFS-15878 Fix checkstyle.

44f3349

ayushtkn approved these changes May 25, 2022

View reviewed changes

ayushtkn merged commit 835f39c into apache:trunk May 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo… #4340

HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo… #4340

HanleyYang commented May 22, 2022 •

edited

Loading

hadoop-yetus commented May 22, 2022

hadoop-yetus commented May 24, 2022

ayushtkn left a comment

ayushtkn commented May 28, 2022

HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo… #4340

HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo… #4340

Conversation

HanleyYang commented May 22, 2022 • edited Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented May 22, 2022

hadoop-yetus commented May 24, 2022

ayushtkn left a comment

Choose a reason for hiding this comment

ayushtkn commented May 28, 2022

HanleyYang commented May 22, 2022 •

edited

Loading