HADOOP-18302. Remove WhiteBox in hadoop-common module. #4457

slfan1989 · 2022-06-18T03:54:06Z

JIRA:HADOOP-18302. Remove WhiteBox in hadoop-common module.

In HADOOP-18277 Jira, the removal of Whitebox was discussed,
aajisaka suggested that the relevant code needs to be refactored to completely remove the Whitebox class, I tried to refactor the code in this pr.

aajisaka

-1

Please read https://issues.apache.org/jira/browse/HADOOP-18277?focusedCommentId=17564659&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17564659

slfan1989 · 2022-07-10T12:20:33Z

@aajisaka Thanks for your suggestion, I will refactor the code.

aajisaka

When adding getter and setter, use limited scope as possible. You should consider in the order package-private -> protected -> public. In addition, would you add @VisibleForTesting to specify it is used only from tests?

slfan1989 · 2022-07-11T23:56:58Z

@aajisaka Thank you for helping to review the code, I will fix it as soon as possible.

slfan1989 · 2022-08-21T00:04:30Z

@aajisaka Please help me to review the code again, thank you very much!

hadoop-yetus · 2022-08-24T05:23:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 11 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 37s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 48s		trunk passed
+1 💚	compile	23m 20s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 47s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 58s		trunk passed
+1 💚	mvnsite	3m 29s		trunk passed
+1 💚	javadoc	3m 0s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	2m 32s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 38s		trunk passed
+1 💚	shadedclient	21m 45s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	22m 15s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 35s		the patch passed
+1 💚	compile	22m 25s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 25s		root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 2833 unchanged - 17 fixed = 2833 total (was 2850)
+1 💚	compile	20m 38s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 38s		root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 2629 unchanged - 17 fixed = 2629 total (was 2646)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 48s		hadoop-common-project: The patch generated 0 new + 377 unchanged - 233 fixed = 377 total (was 610)
+1 💚	mvnsite	3m 27s		the patch passed
+1 💚	javadoc	2m 39s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	2m 12s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 23s		the patch passed
+1 💚	shadedclient	21m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 35s		hadoop-common in the patch passed.
+1 💚	unit	1m 28s		hadoop-nfs in the patch passed.
+1 💚	asflicense	1m 15s		The patch does not generate ASF License warnings.
		230m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/25/artifact/out/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 9f5883da13fb 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `57ecde4`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/25/testReport/
Max. process+thread count	2464 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/25/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-08-30T08:42:29Z

@aajisaka Please help me to review the code again, thank you very much!

aajisaka · 2022-08-30T11:54:56Z

hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/portmap/RpcProgramPortmap.java

@@ -208,4 +209,8 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable t) {
    LOG.warn("Encountered ", t);
    ctx.channel().close();
  }
+
+  public Map<String, PortmapMapping> getMap() {


Should be package-private and annotated with @VisibleForTesting.

...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java

aajisaka · 2022-08-30T12:15:32Z

...common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java

+  public Graphite getGraphite() {
+    return graphite;
+  }

+  public void setGraphite(Graphite graphite) {
+    this.graphite = graphite;
+  }


Thank you @slfan1989, but I disagree with replicating the class because we have to manually update the test class if there is any change in the original class. Instead, can we make MetricsRecordImpl.java public? Reference:

hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsCollectorImpl.java

Lines 34 to 36 in e103c83

@InterfaceAudience.Private

@VisibleForTesting

public class MetricsCollectorImpl implements MetricsCollector,

hadoop-yetus · 2022-08-30T18:31:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 1s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	17m 27s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 29s		trunk passed
+1 💚	compile	23m 23s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	20m 30s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 38s		trunk passed
+1 💚	mvnsite	2m 56s		trunk passed
+1 💚	javadoc	2m 40s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	2m 11s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 4s		trunk passed
+1 💚	shadedclient	21m 9s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	21m 34s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 30s		the patch passed
+1 💚	compile	22m 28s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	22m 28s		root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 2839 unchanged - 17 fixed = 2839 total (was 2856)
+1 💚	compile	20m 36s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 36s		root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 2635 unchanged - 17 fixed = 2635 total (was 2652)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 30s		hadoop-common-project: The patch generated 0 new + 378 unchanged - 234 fixed = 378 total (was 612)
+1 💚	mvnsite	2m 56s		the patch passed
+1 💚	javadoc	2m 16s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 55s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 23s		the patch passed
+1 💚	shadedclient	21m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 46s		hadoop-common in the patch passed.
+1 💚	unit	1m 16s		hadoop-nfs in the patch passed.
+1 💚	asflicense	1m 18s		The patch does not generate ASF License warnings.
		227m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/26/artifact/out/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 19a4e786ff13 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `27fd624`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/26/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/26/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-08-30T18:44:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 3s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 10s		trunk passed
+1 💚	compile	24m 55s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	22m 12s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 43s		trunk passed
+1 💚	mvnsite	2m 57s		trunk passed
+1 💚	javadoc	2m 37s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 57s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 24s		trunk passed
+1 💚	shadedclient	23m 2s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	23m 30s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 30s		the patch passed
+1 💚	compile	23m 53s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	23m 53s		root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 2839 unchanged - 17 fixed = 2839 total (was 2856)
+1 💚	compile	22m 2s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	22m 2s		root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~~20.04-b07 generated 0 new + 2635 unchanged - 17 fixed = 2635 total (was 2652)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 36s		hadoop-common-project: The patch generated 0 new + 379 unchanged - 234 fixed = 379 total (was 613)
+1 💚	mvnsite	3m 6s		the patch passed
+1 💚	javadoc	2m 32s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	2m 23s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 25s		the patch passed
+1 💚	shadedclient	21m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 30s		hadoop-common in the patch passed.
+1 💚	unit	1m 25s		hadoop-nfs in the patch passed.
+1 💚	asflicense	1m 15s		The patch does not generate ASF License warnings.
		237m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/27/artifact/out/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b82af93b05d3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `27fd624`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/27/testReport/
Max. process+thread count	3159 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/27/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-08-31T07:31:44Z

@aajisaka Can you help review this pr again? Thank you very much!

aajisaka

I'm +1 if the below comment is addressed. Thank you for the update, @slfan1989

...n-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsRecordImpl.java

hadoop-yetus · 2022-09-11T14:51:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 1s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 30s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 21s		trunk passed
+1 💚	compile	25m 37s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	21m 54s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 36s		trunk passed
+1 💚	mvnsite	2m 43s		trunk passed
+1 💚	javadoc	2m 19s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 44s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 5s		trunk passed
+1 💚	shadedclient	24m 27s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	24m 52s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 29s		the patch passed
+1 💚	compile	24m 33s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	24m 33s		root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 2836 unchanged - 17 fixed = 2836 total (was 2853)
+1 💚	compile	21m 55s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 55s		root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 2635 unchanged - 17 fixed = 2635 total (was 2652)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 27s		hadoop-common-project: The patch generated 0 new + 379 unchanged - 234 fixed = 379 total (was 613)
+1 💚	mvnsite	2m 43s		the patch passed
+1 💚	javadoc	2m 6s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 45s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 13s		the patch passed
+1 💚	shadedclient	24m 15s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 35s		hadoop-common in the patch passed.
+1 💚	unit	1m 8s		hadoop-nfs in the patch passed.
+1 💚	asflicense	1m 9s		The patch does not generate ASF License warnings.
		238m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/28/artifact/out/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c777e392c259 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7421ba8`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/28/testReport/
Max. process+thread count	1381 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/28/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-09-11T15:12:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 46s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 35s		trunk passed
+1 💚	compile	23m 6s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	20m 49s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 41s		trunk passed
+1 💚	mvnsite	3m 18s		trunk passed
+1 💚	javadoc	2m 33s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 15s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 4s		trunk passed
+1 💚	shadedclient	20m 59s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	21m 25s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 32s		the patch passed
+1 💚	compile	22m 34s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	22m 34s		root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 2836 unchanged - 17 fixed = 2836 total (was 2853)
+1 💚	compile	20m 39s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 39s		root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 2633 unchanged - 17 fixed = 2633 total (was 2650)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 29s		hadoop-common-project: The patch generated 0 new + 378 unchanged - 234 fixed = 378 total (was 612)
+1 💚	mvnsite	2m 53s		the patch passed
+1 💚	javadoc	2m 23s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 11s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 50s		the patch passed
+1 💚	shadedclient	23m 34s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 36s		hadoop-common in the patch passed.
+1 💚	unit	1m 24s		hadoop-nfs in the patch passed.
+1 💚	asflicense	1m 21s		The patch does not generate ASF License warnings.
		228m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/29/artifact/out/Dockerfile
GITHUB PR	#4457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c9ef2b1ddaad 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `82a3cc9`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/29/testReport/
Max. process+thread count	1301 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4457/29/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-09-12T01:32:56Z

@aajisaka Please help to review the code again, thank you very much!

aajisaka

+1

aajisaka · 2022-09-12T14:28:30Z

Merged into trunk. Thank you so much for your contribution, @slfan1989 !

slfan1989 · 2022-09-13T00:11:42Z

@aajisaka Thank you very much for helping to review the code!

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

HADOOP-18302. Remove WhiteBox in hadoop-commmon module.

401ae5a

slfan1989 changed the title ~~HADOOP-18302. Remove WhiteBox in hadoop-commmon module.~~ HADOOP-18302. Remove WhiteBox in hadoop-common module. Jun 18, 2022

slfan1989 added 2 commits June 17, 2022 23:21

HADOOP-18302. Remove WhiteBox in hadoop-commmon module.

9c382a2

HADOOP-18302. Remove WhiteBox in hadoop-common module.

d101a55

This comment was marked as outdated.

Sign in to view

HADOOP-18302. Remove WhiteBox in hadoop-common module.

5918769

This comment was marked as outdated.

Sign in to view

Merge branch 'apache:trunk' into HADOOP-18302

24ac36b

This comment was marked as outdated.

Sign in to view

slfan1989 and others added 2 commits June 20, 2022 16:05

Merge branch 'apache:trunk' into HADOOP-18302

a2f7bdb

HADOOP-18302. Fix CheckStyle.

e30456b

This comment was marked as outdated.

Sign in to view

aajisaka requested changes Jul 10, 2022

View reviewed changes

slfan1989 and others added 4 commits July 10, 2022 05:22

Merge branch 'apache:trunk' into HADOOP-18302

185c165

HADOOP-18302. Remove WhiteBox in hadoop-common module.

891427d

HADOOP-18302. Remove WhiteBox in hadoop-common module.

536c143

HADOOP-18302. Remove WhiteBox in hadoop-common module.

2625e1d

This comment was marked as outdated.

Sign in to view

HADOOP-18302. Fix CheckStyle.

2594eb0

This comment was marked as outdated.

Sign in to view

aajisaka requested changes Jul 11, 2022

View reviewed changes

HADOOP-18302. Fix CheckStyle.

2eab504

This comment was marked as outdated.

Sign in to view

Merge branch 'apache:trunk' into HADOOP-18302

d835bfe

This comment was marked as outdated.

Sign in to view

slfan1989 requested a review from aajisaka August 19, 2022 05:46

HADOOP-18302. Fix CheckStyle.

839dc70

This comment was marked as outdated.

Sign in to view

Merge branch 'apache:trunk' into HADOOP-18302

57ecde4

aajisaka requested changes Aug 30, 2022

View reviewed changes

slfan1989 added 2 commits August 30, 2022 07:42

HADOOP-18302. Fix CheckStyle.

bff5a07

HADOOP-18302. Fix CheckStyle.

27fd624

slfan1989 requested review from aajisaka and removed request for aajisaka August 31, 2022 07:31

aajisaka requested changes Sep 10, 2022

View reviewed changes

...n-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsRecordImpl.java Show resolved Hide resolved

slfan1989 and others added 2 commits September 11, 2022 18:51

Merge branch 'apache:trunk' into HADOOP-18302

7421ba8

HADOOP-18302. Fix CheckStyle.

82a3cc9

slfan1989 requested a review from aajisaka September 12, 2022 01:30

aajisaka approved these changes Sep 12, 2022

View reviewed changes

aajisaka merged commit cde1f3a into apache:trunk Sep 12, 2022

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-18302. Remove WhiteBox in hadoop-common module. (apache#4457)

57bc479

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18302. Remove WhiteBox in hadoop-common module. #4457

HADOOP-18302. Remove WhiteBox in hadoop-common module. #4457

slfan1989 commented Jun 18, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

aajisaka left a comment

slfan1989 commented Jul 10, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

aajisaka left a comment

slfan1989 commented Jul 11, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

slfan1989 commented Aug 21, 2022

hadoop-yetus commented Aug 24, 2022

slfan1989 commented Aug 30, 2022

aajisaka Aug 30, 2022

aajisaka Aug 30, 2022

hadoop-yetus commented Aug 30, 2022

hadoop-yetus commented Aug 30, 2022

slfan1989 commented Aug 31, 2022 •

edited

Loading

aajisaka left a comment

hadoop-yetus commented Sep 11, 2022

hadoop-yetus commented Sep 11, 2022

slfan1989 commented Sep 12, 2022

aajisaka left a comment

aajisaka commented Sep 12, 2022

slfan1989 commented Sep 13, 2022

	@InterfaceAudience.Private
	@VisibleForTesting
	public class MetricsCollectorImpl implements MetricsCollector,

HADOOP-18302. Remove WhiteBox in hadoop-common module. #4457

HADOOP-18302. Remove WhiteBox in hadoop-common module. #4457

Conversation

slfan1989 commented Jun 18, 2022 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

aajisaka left a comment

Choose a reason for hiding this comment

slfan1989 commented Jul 10, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

aajisaka left a comment

Choose a reason for hiding this comment

slfan1989 commented Jul 11, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

slfan1989 commented Aug 21, 2022

hadoop-yetus commented Aug 24, 2022

slfan1989 commented Aug 30, 2022

aajisaka Aug 30, 2022

Choose a reason for hiding this comment

aajisaka Aug 30, 2022

Choose a reason for hiding this comment

hadoop-yetus commented Aug 30, 2022

hadoop-yetus commented Aug 30, 2022

slfan1989 commented Aug 31, 2022 • edited Loading

aajisaka left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Sep 11, 2022

hadoop-yetus commented Sep 11, 2022

slfan1989 commented Sep 12, 2022

aajisaka left a comment

Choose a reason for hiding this comment

aajisaka commented Sep 12, 2022

slfan1989 commented Sep 13, 2022

slfan1989 commented Jun 18, 2022 •

edited

Loading

slfan1989 commented Aug 31, 2022 •

edited

Loading