YARN-11161. Support getAttributesToNodes, getClusterNodeAttributes, getNodesToAttributes API's for Federation #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etNodesToAttributes API's for Federation.
|
🎊 +1 overall
This message was automatically generated. |
…etNodesToAttributes API's for Federation.
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 22, 2022
...src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java
Show resolved
Hide resolved
| } | ||
| } | ||
| attributesToNodesResponse.setAttributeToNodes(nodeAttributeMap); | ||
| return attributesToNodesResponse; |
There was a problem hiding this comment.
Can we do something like:
return GetAttributesToNodesResponse.newInstance(nodeAttributeMap);
There was a problem hiding this comment.
Thanks for your suggestion, I will modify the code.
| Set<NodeAttributeInfo> nodeAttributeInfos = response.getNodeAttributes(); | ||
| Assert.assertEquals(2, nodeAttributeInfos.size()); | ||
|
|
||
| Object[] objectArr = nodeAttributeInfos.toArray(); |
There was a problem hiding this comment.
Assert the size of the array here too?
There was a problem hiding this comment.
Actually, this thing about converting a set into an array to then check in a specific order is not very clean.
There was a problem hiding this comment.
I will refactor this code to use the methods provided by Set directly.
| Assert.assertEquals("rm.yarn.io/CPU(STRING)", objectArr[1].toString()); | ||
| } | ||
|
|
||
| private boolean findHostnameAndValInMapping(String hostname, String attrVal, |
| Assert.assertEquals(2, response.getAttributesToNodes().size()); | ||
|
|
||
| Map<NodeAttributeKey, List<NodeToAttributeValue>> attrs = response.getAttributesToNodes(); | ||
| Assert.assertTrue(findHostnameAndValInMapping("node2", "docker0", |
There was a problem hiding this comment.
Not the cleanest. Is there a better way of writing this?
…etNodesToAttributes API's for Federation.
goiri
approved these changes
Jul 22, 2022
...src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 23, 2022
...r/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 23, 2022
| @@ -196,11 +195,11 @@ public void init(String userName) { | |||
| } | |||
|
|
|||
| numSubmitRetries = | |||
There was a problem hiding this comment.
This indentation is not very clean.
Let's make it numSubmitRetries = conf.getInt(
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jul 24, 2022
|
@goiri I added a part of Junit Test code in TestFederationClientInterceptor.java, please help to review the code again, thank you very much! |
|
@goiri |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jul 25, 2022
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…etNodesToAttributes API's for Federation (apache#4610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:YARN-11161. Support getAttributesToNodes, getClusterNodeAttributes, getNodesToAttributes API's for Federation.