Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-15980. Securing Hadoop RPC using SSL #4638

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

vnhive
Copy link

@vnhive vnhive commented Jul 27, 2022

The work done in this pull request implements SSL support for Hadoop RPC using the following steps,

  1. Add SSL support to the RPC server
    a. Creates a RPC server implementation (Server.java) to use Netty
    b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
    c. Add SSL Handlers to the Netty Pipeline
    d. Parameterizes the RPC unit tests to run with and without SSL.
    e. Split the new classes into the constituent source files to reduce the clutter in Server.java.

  2. Add Netty support to the RPC client
    a. Creates a RPC Client implementation (Client.java) to use Netty
    b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
    c. Add SSL Handlers to the Netty Pipeline
    d. Parameterizes the RPC unit tests to run with and without Netty.
    e. Split the new classes into the constituent source files to reduce the clutter in Client.java.

  3. Add configuration to turn Netty on and off.

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

The work done in this pull request implements SSL support for Hadoop RPC using the following steps,

1. Add SSL support to the RPC server
   a. Creates a RPC server implementation (Server.java) to use Netty
   b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
   c. Add SSL Handlers to the Netty Pipeline
   d. Parameterizes the RPC unit tests to run with and without SSL.
   e. Split the new classes into the constituent source files to reduce the clutter in Server.java.

2. Add Netty support to the RPC client
   a. Creates a RPC Client implementation (Client.java) to use Netty
   b. Juxtaposes the Netty Implementation alongside the Native Java NIO APIs.
   c. Add SSL Handlers to the Netty Pipeline
   d. Parameterizes the RPC unit tests to run with and without Netty.
   e. Split the new classes into the constituent source files to reduce the clutter in Client.java.

3. Add configuration to turn Netty on and off.
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 16 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 23s Maven dependency ordering for branch
+1 💚 mvninstall 25m 17s trunk passed
+1 💚 compile 23m 21s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 20m 54s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 4m 28s trunk passed
+1 💚 mvnsite 5m 42s trunk passed
+1 💚 javadoc 4m 41s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 4m 42s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 1m 13s branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 21m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 38s Maven dependency ordering for patch
+1 💚 mvninstall 6m 42s the patch passed
+1 💚 compile 22m 35s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
-1 ❌ javac 22m 35s /results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 3 new + 2879 unchanged - 1 fixed = 2882 total (was 2880)
+1 💚 compile 20m 57s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌ javac 20m 57s /results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu120.04-b07 generated 3 new + 2674 unchanged - 1 fixed = 2677 total (was 2675)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 4m 19s /results-checkstyle-root.txt root: The patch generated 175 new + 642 unchanged - 129 fixed = 817 total (was 771)
+1 💚 mvnsite 5m 37s the patch passed
-1 ❌ javadoc 1m 40s /patch-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt hadoop-common in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚 javadoc 4m 51s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 ❌ spotbugs 3m 16s /new-spotbugs-hadoop-common-project_hadoop-common.html hadoop-common-project/hadoop-common generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+0 🆗 spotbugs 1m 13s hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚 shadedclient 21m 27s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 21m 11s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
-1 ❌ unit 383m 34s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 1m 36s hadoop-client-minicluster in the patch passed.
+1 💚 asflicense 2m 2s The patch does not generate ASF License warnings.
651m 28s
Reason Tests
SpotBugs module:hadoop-common-project/hadoop-common
Self assignment of field Connection.isOnAuxiliaryPort in new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:in new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:[line 148]
Uninitialized read of isOnAuxiliaryPort in new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:new org.apache.hadoop.ipc.netty.server.Connection(Server, Object, InetSocketAddress, InetSocketAddress) At Connection.java:[line 148]
Inconsistent synchronization of org.apache.hadoop.ipc.netty.server.NioListener.selector; locked 62% of time Unsynchronized access at NioListener.java:62% of time Unsynchronized access at NioListener.java:[line 115]
new org.apache.hadoop.ipc.netty.server.NioListener(Server, int) invokes org.apache.hadoop.ipc.netty.server.NioListener$Reader.start() At NioListener.java: At NioListener.java:[line 83]
Failed junit tests hadoop.ipc.TestRPC
hadoop.ipc.TestProtoBufRpc
hadoop.hdfs.TestBlockTokenWrappingQOP
hadoop.hdfs.TestMultipleNNPortQOP
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4638/1/artifact/out/Dockerfile
GITHUB PR #4638
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux e6cc1e47eb52 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e25d4d0
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4638/1/testReport/
Max. process+thread count 3448 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-client-modules/hadoop-client-minicluster U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4638/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants