-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-10846. Add dispatcher metrics to NM. #4687
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@goiri @ayushtkn @szilard-nemeth Can you help review this PR? I refer to the code of YARN-9615 and the YARN-10846 patch to complete this pr. This pr adds some metrics to NM's dispatcher. metric is as follows: |
🎊 +1 overall
This message was automatically generated. |
@jojochuang Can you help review this PR? I refer to the code of YARN-9615 and the YARN-10846 patch to complete this pr. This pr adds some metrics to NM's dispatcher. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@jojochuang Can you help review this part of the code? Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@jojochuang Can you help review the code? Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@9uapaw Can you help review the code again? Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@9uapaw Can you help review the code again? Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@9uapaw Can you help review this PR again? Thank you very much! |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
protected AsyncDispatcher createContainerManagerDispatcher() { | ||
dispatcher = new AsyncDispatcher("NM ContainerManager dispatcher"); | ||
|
||
if (nmDispatherMetricEnabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe easier to read as:
if (!nmDispatherMetricEnabled) {
return dispatcher;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion, I will modify the code.
🎊 +1 overall
This message was automatically generated. |
There are a couple checkstyle warnings left. |
@goiri Thank you very much for your help to review the code! I will modify the code. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Thank you very much for helping to review the code! |
JIRA: YARN-10846. Add dispatcher metrics to NM.