-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16729.RBF: fix some unreasonably annotated docs. #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jianghuazhu
force-pushed
the
HDFS-16729
branch
from
August 16, 2022 09:34
7913080
to
c30e75e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jianghuazhu
force-pushed
the
HDFS-16729
branch
from
August 16, 2022 12:00
c30e75e
to
20d4477
Compare
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Aug 16, 2022
Samrat002
approved these changes
Aug 18, 2022
Thank you, @goiri @Samrat002 . |
@goiri , can you help merge this pr into the trunk branch? |
aajisaka
approved these changes
Aug 20, 2022
Thank you @jianghuazhu for your contribution and thank you @goiri and @Samrat002 for your reviews. |
aajisaka
pushed a commit
that referenced
this pull request
Aug 20, 2022
Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 7f176d0)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In the RBF module, there is some unreasonably annotated documentation, the purpose of this pr is to try and fix.
Details: HDFS-16729
How was this patch tested?
This is mainly related to documentation, and the test pressure is not large.