YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL. #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ieval of Reservations With SQL.
slfan1989
changed the title
|
🎊 +1 overall
This message was automatically generated. |
added 3 commits
August 29, 2022 17:11
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Aug 29, 2022
|
|
||
| while (rs.next()) { | ||
| // Extract the output for each tuple | ||
| String dbReservationId = rs.getString(1); |
There was a problem hiding this comment.
Is there a better way to having indices?
There was a problem hiding this comment.
Thank you very much for your suggestion, I agree with your point of view, the readability of this part of the code is really not very good, I add some comments and name the variables for indices.
| // if it is different from 1 it means the call | ||
| // had a wrong behavior. Maybe the database is not set correctly. | ||
| FederationStateStoreUtils.logAndThrowStoreException(LOG, | ||
| "Wrong behavior during deleting the reservation %s.", reservationId); |
There was a problem hiding this comment.
I will describe the exception message in more detail.
...c/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Please help to review the code, thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Please help to review the code again, thank you very much! I have refactored the code as follows:
|
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Sep 1, 2022
...st/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.java
Show resolved
Hide resolved
...st/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.java
Show resolved
Hide resolved
| @@ -76,38 +107,479 @@ public void testSqlConnectionsCreatedCount() throws YarnException { | |||
| FederationStateStoreClientMetrics.getNumConnections()); | |||
| } | |||
|
|
|||
| @Test(expected = NotImplementedException.class) | |||
| public void testAddReservationHomeSubCluster() throws Exception { | |||
There was a problem hiding this comment.
Should we just remove this?
It will call the parent methods by default right?
We should check the unit test report.
There was a problem hiding this comment.
Should we just remove this?
It will call the parent methods by default right?
Your understanding is accurate, we can delete all this method. When the test is executed, it will call the parent methods by default, but deleting it directly will bring some difficulties to the review, because it will be difficult to compare the code. I will later Submit a refactored pr. For code refactoring, these redundant codes will be deleted directly at that time.
There was a problem hiding this comment.
Can we do this in this PR?
We can check the unit tests results for all this.
There was a problem hiding this comment.
I will modify the code, but when the code is compared, there may be misalignments.
goiri
reviewed
Sep 1, 2022
| FederationStateStoreUtils.returnToPool(LOG, cstmt); | ||
| } | ||
|
|
||
| ReservationHomeSubCluster homeSubCluster = |
There was a problem hiding this comment.
If we get an exception we return null values?
There was a problem hiding this comment.
Thank you very much for helping to review the code, I will modify the code. In the case of an exception, the exception should be thrown directly, so the handling should be better.
...c/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java
Show resolved
Hide resolved
| @@ -76,38 +107,479 @@ public void testSqlConnectionsCreatedCount() throws YarnException { | |||
| FederationStateStoreClientMetrics.getNumConnections()); | |||
| } | |||
|
|
|||
| @Test(expected = NotImplementedException.class) | |||
| public void testAddReservationHomeSubCluster() throws Exception { | |||
There was a problem hiding this comment.
Can we do this in this PR?
We can check the unit tests results for all this.
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Please help to review the code, thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Sep 2, 2022
|
@goiri Thanks for your help reviewing the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…vations With SQL. (apache#4817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11273. [RESERVATION] Federation StateStore: Support storage/retrieval of Reservations With SQL.