-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18472: snakeyaml 1.33 #4958
Conversation
💔 -1 overall
This message was automatically generated. |
12d98d4
to
ec7bcf1
Compare
💔 -1 overall
This message was automatically generated. |
@ashutoshcipher would you have time to look at this? snakeyaml 1.32 security fix had a shortcoming that was fixed in 1.33 |
Thanks @pjfanning - I will look into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the UT failures once and if those are intermediate - you can trigger jenkins once again. Thanks.
ec7bcf1
to
185aa5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (Jenkins pending)
185aa5e
to
c27bc00
Compare
💔 -1 overall
This message was automatically generated. |
@ashutoshcipher @steveloughran the test failure appears not be an issue when I run on my laptop - I think it was just an intermittent CI issue |
Thanks @pjfanning . Would you like to trigger jenkins once again? |
c27bc00
to
e1da0c3
Compare
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thank you @pjfanning for your contribution and thanks @dineshchitlangia and @ashutoshcipher for your review. |
Reviewed-by: Dinesh Chitlangia <dineshc@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit d6a65a4) Conflicts: LICENSE-binary hadoop-project/pom.xml
Reviewed-by: Dinesh Chitlangia <dineshc@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Dinesh Chitlangia <dineshc@apache.org> Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit df66d0e) Change-Id: I3afadad127340727a5adafcb9efceee38349fb5f (cherry picked from commit 8cb59330149ee39e003c7564a9d2d6e2c1810fa6)
Description of PR
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?