YARN-11337. Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo #4993

ashutoshcipher · 2022-10-10T00:01:34Z

Description of PR

Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo

JIRA - YARN-11337

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

slfan1989 · 2022-10-10T01:06:27Z

@ashutoshcipher Thanks for your contribution, LGTM.

hadoop-yetus · 2022-10-10T01:39:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 26s		trunk passed
+1 💚	compile	0m 23s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 20s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 25s		trunk passed
+1 💚	mvnsite	0m 26s		trunk passed
+1 💚	javadoc	0m 32s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 21s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 46s		trunk passed
+1 💚	shadedclient	22m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	0m 17s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 17s		the patch passed
+1 💚	compile	0m 14s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 12s		the patch passed
+1 💚	mvnsite	0m 18s		the patch passed
+1 💚	javadoc	0m 17s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 16s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 38s		the patch passed
+1 💚	shadedclient	22m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 23s		hadoop-yarn-applications-mawo-core in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		96m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4993/1/artifact/out/Dockerfile
GITHUB PR	#4993
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 425edafef9c6 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6337058`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4993/1/testReport/
Max. process+thread count	598 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4993/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ashutoshcipher · 2022-10-10T01:53:08Z

@aajisaka , Please help in reviewing this PR.

aajisaka

Thanks, added comments. In addition, do you think we need to add junit-platform-launcher dependency in pom.xml?

aajisaka · 2022-10-25T07:48:31Z

...e/src/test/java/org/apache/hadoop/applications/mawo/server/common/TestMaWoConfiguration.java


    MawoConfiguration mawoConf = new MawoConfiguration();

    // validate Rpc server port
-    Assert.assertEquals(mawoConf.getRpcServerPort(), 5120);
+    assertEquals(mawoConf.getRpcServerPort(), 5120);


Would you fix the order of the argument as follows?

assertEquals(5120, mawoConf.getRpcServerPort());

aajisaka · 2022-10-25T07:48:50Z

...e/src/test/java/org/apache/hadoop/applications/mawo/server/common/TestMaWoConfiguration.java


    // validate default teardownWorkerValidity Interval
-    Assert.assertEquals(mawoConf.getTeardownWorkerValidityInterval(), 120000);
+    assertEquals(mawoConf.getTeardownWorkerValidityInterval(), 120000);


Should be assertEquals(120000, mawoConf.getTeardownWorkerValidityInterval());

ashutoshcipher · 2022-10-25T07:55:49Z

Thanks @aajisaka for reviewing, I will address you comments in my next commit and also add junit-platform-launcher which missed.

hadoop-yetus · 2022-10-25T10:47:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	17m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 39s		trunk passed
+1 💚	compile	0m 23s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 20s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 24s		trunk passed
+1 💚	mvnsite	0m 26s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 21s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 46s		trunk passed
+1 💚	shadedclient	22m 50s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 18s		the patch passed
+1 💚	compile	0m 17s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 17s		the patch passed
+1 💚	compile	0m 14s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 14s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 11s		the patch passed
+1 💚	mvnsite	0m 17s		the patch passed
+1 💚	javadoc	0m 15s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 16s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 38s		the patch passed
+1 💚	shadedclient	22m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 22s		hadoop-yarn-applications-mawo-core in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		113m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4993/2/artifact/out/Dockerfile
GITHUB PR	#4993
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 31f59404c81c 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `155a1be`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4993/2/testReport/
Max. process+thread count	600 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-mawo/hadoop-yarn-applications-mawo-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4993/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

aajisaka

LGTM

ashutoshcipher · 2022-10-29T17:27:03Z

Thanks @aajisaka for reviewing/merging.

…ache#4993) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

YARN-11337. Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo

6337058

slfan1989 approved these changes Oct 10, 2022

View reviewed changes

ashutoshcipher marked this pull request as ready for review October 10, 2022 01:53

aajisaka requested changes Oct 25, 2022

View reviewed changes

Adding junit-platform-launcher and addressing comments

155a1be

aajisaka approved these changes Oct 25, 2022

View reviewed changes

aajisaka merged commit 2aae7ff into apache:trunk Oct 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11337. Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo #4993

YARN-11337. Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo #4993

ashutoshcipher commented Oct 10, 2022

slfan1989 commented Oct 10, 2022

hadoop-yetus commented Oct 10, 2022

ashutoshcipher commented Oct 10, 2022

aajisaka left a comment

aajisaka Oct 25, 2022

aajisaka Oct 25, 2022

ashutoshcipher commented Oct 25, 2022

hadoop-yetus commented Oct 25, 2022

aajisaka left a comment

ashutoshcipher commented Oct 29, 2022

YARN-11337. Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo #4993

YARN-11337. Upgrade Junit 4 to 5 in hadoop-yarn-applications-mawo #4993

Conversation

ashutoshcipher commented Oct 10, 2022

Description of PR

For code changes:

slfan1989 commented Oct 10, 2022

hadoop-yetus commented Oct 10, 2022

ashutoshcipher commented Oct 10, 2022

aajisaka left a comment

Choose a reason for hiding this comment

aajisaka Oct 25, 2022

Choose a reason for hiding this comment

aajisaka Oct 25, 2022

Choose a reason for hiding this comment

ashutoshcipher commented Oct 25, 2022

hadoop-yetus commented Oct 25, 2022

aajisaka left a comment

Choose a reason for hiding this comment

ashutoshcipher commented Oct 29, 2022