Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18183. s3a audit logs to publish range start/end of GET requests. #5218

Merged

Conversation

steveloughran
Copy link
Contributor

The start and end of the range is set in a new audit param "rg", e.g "?rg=100-200"

Contributed by Ankit Saurabh

How was this patch tested?

s3 london

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

The start and end of the range is set in a new audit param "rg",
e.g "?rg=100-200"

Contributed by Ankit Saurabh
@steveloughran
Copy link
Contributor Author

this is just #5110 with two changes

  • newline in logging message (checkstyle)
  • changed audit.md to say GET not GetObjectRequest

if yetus is happy will merge

@steveloughran
Copy link
Contributor Author

build was happy locally; test s3 london @ scale, and verified in logs that things worked

183c9826b45486e485693808f38e2c4071004bf5dfd4c3ab210f0a21a4235ef8 stevel-london [14/Dec/2022:12:59:35 +0000] 109.157.193.147 arn:aws:iam::152813717728:user/stevel-dev 446CNGJCGD6DCZ4D REST.GET.OBJECT fork-0007/test/testReadSingleByteAcrossReadahead-sequential "GET /fork-0007/test/testReadSingleByteAcrossReadahead-sequential?versionId=uWXlWeVE5kCrTG.TRmC4gNekp5yWrELr HTTP/1.1" 206 - 2048 2048 28 14 "https://audit.example.org/hadoop/1/op_open/be0d9c4a-964e-423d-b22b-7fa5b56db268-00000029/?op=op_open&p1=fork-0007/test/testReadSingleByteAcrossReadahead-sequential&pr=stevel&ps=d12bd202-8831-4faf-965e-f3d7f23c3782&rg=0-2047&id=be0d9c4a-964e-423d-b22b-7fa5b56db268-00000029&t0=53&fs=be0d9c4a-964e-423d-b22b-7fa5b56db268&t1=53&ts=1671022775232" 

here rg=0-2047; a single byte was read in a stream with sequential read and readahead.

I am happy with this and doing the merge, as it is a yetus issue and have just done the testing locally.

@steveloughran steveloughran merged commit 1cecf8a into apache:trunk Dec 14, 2022
@steveloughran
Copy link
Contributor Author

merged, backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant