YARN-11469. Refactor FederationStateStoreFacade Cache Code. #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Apr 19, 2023
| StringBuilder buffer = new StringBuilder(); | ||
| buffer.append(typeName).append(".").append(methodName); | ||
| if (argName != null) { | ||
| buffer.append("::"); |
| @@ -0,0 +1,263 @@ | |||
| package org.apache.hadoop.yarn.server.federation.cache; | |||
|
|
|||
| cacheTimeToLive = conf.getInt(YarnConfiguration.FEDERATION_CACHE_TIME_TO_LIVE_SECS, | ||
| YarnConfiguration.DEFAULT_FEDERATION_CACHE_TIME_TO_LIVE_SECS); | ||
| this.stateStore = pStateStore; | ||
| if (cacheTimeToLive > 0) { |
There was a problem hiding this comment.
Thanks for your suggestion, I will modify the code.
| FactoryBuilder.SingletonFactory<CacheLoader<Object, Object>> cacheLoaderSingletonFactory = | ||
| new FactoryBuilder.SingletonFactory<>(new CacheLoaderImpl<>()); | ||
| CompleteConfiguration<Object, Object> configuration = | ||
| new MutableConfiguration<>().setStoreByValue(false) |
There was a problem hiding this comment.
I will modify the code.
|
|
||
| @Override | ||
| public int hashCode() { | ||
| final int prime = 31; |
There was a problem hiding this comment.
Can we use the HashBuilder and the EqualsBuilder?
| Boolean.toString(filterInactiveSubClusters)); | ||
| CacheRequest<String, Map<SubClusterId, SubClusterInfo>> cacheRequest = | ||
| new CacheRequest<>(cacheKey, | ||
| key -> { |
There was a problem hiding this comment.
We don't do anything with the key?
There was a problem hiding this comment.
I will refactor this part of the code.
| GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, applicationId.toString()); | ||
| CacheRequest<String, SubClusterId> cacheRequest = new CacheRequest<>( | ||
| cacheKey, | ||
| input -> { |
There was a problem hiding this comment.
I will modify the code.
|
|
||
| public abstract void clearCache(); | ||
|
|
||
| protected String buildCacheKey(String typeName, String methodName, String argName) { |
There was a problem hiding this comment.
Put documentation with examples of input and outputs.
There was a problem hiding this comment.
Thanks for your suggestion! I will improve the documentation.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Thank you very much for helping to review the code! I am currently refactoring a cache implementation to support additional cache implementations in the future. To aid me in this process, I have referred to The Ehcache 3.x JSR-107 Provider documentation, specifically version 3.10, as a resource. The goal is to improve the code and make it more extensible for future updates. Can you help review the code again? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Apr 24, 2023
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for helping to review the code! |
|
I want to implement a new cache replacement algorithm in hdfs but I don't know which part of module to use and modify. Can any one please help me find the modules and functions which need to override to add my own caching replacement algorithm in hdfs |
slfan1989
added a commit
to slfan1989/hadoop
that referenced
this pull request
May 5, 2024
slfan1989
added a commit
to slfan1989/hadoop
that referenced
this pull request
May 5, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11469. Refactor FederationStateStoreFacade Cache Code.
The Cache of FederationStateStoreFacade uses JCache, but considering that JCache is not a general Cache implementation (the latest version was released in 2014), this part of the code is refactored to support multiple Cache in the future.