-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11470. FederationStateStoreFacade Cache Support Guava Cache. #5609
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Can you help review this pr? Thank you very much! |
🎊 +1 overall
This message was automatically generated. |
...ommon/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationGuavaCache.java
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
@goiri Can you help review this PR again? Thank you very much! I modified |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
public TestFederationCache(String cacheClassName) { | ||
conf = new Configuration(); | ||
conf.setInt(YarnConfiguration.FEDERATION_CACHE_TIME_TO_LIVE_SECS, 1); | ||
conf.set(YarnConfiguration.FEDERATION_FACADE_CACHE_CLASS, cacheClassName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use setClass and pass the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your suggestion! I will modify the code.
🎊 +1 overall
This message was automatically generated. |
@goiri Thank you very much for helping to review the code! |
Description of PR
JIRA: YARN-11470. FederationStateStoreFacade Cache Support Guava Cache.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?