Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18637. S3A to support upload of files greater than 2 GB using DiskBlocks (#5630) #5641

Merged
merged 1 commit into from
May 15, 2023

Conversation

HarshitGupta11
Copy link
Contributor

Description of PR

Backport of HADOOP-18637

How was this patch tested?

The patch is tested against uswest-2

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…DiskBlocks (apache#5630)

Contributed by Steve Loughran and Harshit Gupta.
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 2m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 5 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 36m 33s branch-3.3 passed
+1 💚 compile 0m 39s branch-3.3 passed
+1 💚 checkstyle 0m 35s branch-3.3 passed
+1 💚 mvnsite 0m 46s branch-3.3 passed
+1 💚 javadoc 0m 41s branch-3.3 passed
+1 💚 spotbugs 1m 21s branch-3.3 passed
+1 💚 shadedclient 24m 5s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 36s the patch passed
+1 💚 compile 0m 29s the patch passed
+1 💚 javac 0m 29s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 20s the patch passed
+1 💚 mvnsite 0m 35s the patch passed
+1 💚 javadoc 0m 24s the patch passed
+1 💚 spotbugs 1m 8s the patch passed
+1 💚 shadedclient 23m 47s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 34s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
99m 29s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5641/1/artifact/out/Dockerfile
GITHUB PR #5641
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint
uname Linux 026421debab8 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 3361f43
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5641/1/testReport/
Max. process+thread count 556 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5641/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

  1. what was missing from the previous cherrypick?
  2. what were the full commands passed in to maven?

@HarshitGupta11
Copy link
Contributor Author

Hi @steveloughran,

  1. Due to the merge resolution, the S3ABlockOutputStreamBuilder was not being properly initialised, also the threadpool was not being initialised with the prefetching threads.
  2. The commands that were used : mvn -Dscale -Dparallel-tests -DtestsThreadCount=8 -fae clean verify

@steveloughran steveloughran merged commit f312a0c into apache:branch-3.3 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants