-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18793: S3A StagingCommitter does not clean up staging-uploads directory #5818
Conversation
Path attemptPath = getJobAttemptPath(context); | ||
ignoreIOExceptions(LOG, | ||
"Deleting Job attempt Path", attemptPath.toString(), | ||
() -> deleteWithWarning( | ||
getJobAttemptFileSystem(context), | ||
attemptPath, | ||
true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these as attemptPath
here is a sub dir under ${UUID}/staging-uploads
, which has already been deleted in deleteStagingUploadsParentDirectory()
.
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! nice tests in particular.
return job; | ||
} | ||
|
||
public JobContext getJContext() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use JobContext and TaskContext in getters, even if field names aren't as informative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i'm not worrying about this; will merge as is.
…directory (#5818) Contributed by Harunobu Daikoku
Thank you for the review 🙏 |
oh, thank for a lovely little patch! |
…directory (apache#5818) Contributed by Harunobu Daikoku
Description of PR
This PR fixes a bug in StagingCommitter, which leaks the staging uploads directory, by deleting the directory in
StagingCommitter#cleanup()
.How was this patch tested?
Ran the integration tests in
org.apache.hadoop.fs.s3a.commit.staging.integration
against a LocalStack instance running on my laptop.For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?