HDFS-17168. Support getTrashRoots API in WebHDFS #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhtttylz
force-pushed
the
HDFS-17168
branch
3 times, most recently
from
f651f6f
to
df0dc45
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Aug 30, 2023
| public static FileStatus toFileStatus(Map<?, ?> json) { | ||
| Path path = new Path(getString(json, "path", "")); | ||
| long length = getLong(json, "length", 0); | ||
| boolean isdir = getBoolean(json, "isdir", false); |
There was a problem hiding this comment.
Can "isdir" be a constant？
There was a problem hiding this comment.
Thanks for your suggestion, I'll make the required code changes promptly
|
@zhtttylz Thank you for your contribution! The code looks fine. |
slfan1989
approved these changes
Aug 30, 2023
slfan1989
reviewed
Aug 31, 2023
| }.run(); | ||
| return trashRoots; | ||
| } catch (IOException e) { | ||
| LOG.warn("Cannot get all trash roots", e); |
There was a problem hiding this comment.
I'll make the required code changes promptly
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@zhtttylz Thanks for your contribution! Merged into trunk. |
|
@slfan1989 Thank you for your assistance in reviewing the code! |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…buted by Hualong Zhang. Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-17168. Support getTrashRoots API in WebHDFS