Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-16197 S3AUtils.translateException to map CredentialInitializationException to AccessDeniedException #619

Closed
wants to merge 2 commits into from
Closed

HADOOP-16197 S3AUtils.translateException to map CredentialInitializationException to AccessDeniedException #619

wants to merge 2 commits into from

Conversation

steveloughran
Copy link
Contributor

HADOOP-16197 S3ATestUtils.translateException to map CredentialInitializationException to AccessDeniedException

Change-Id: Ie98ca5210bf0009f297edbcacf1fc6dfe5ea70cd

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 21 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1103 trunk passed
+1 compile 30 trunk passed
+1 checkstyle 23 trunk passed
+1 mvnsite 35 trunk passed
+1 shadedclient 759 branch has no errors when building and testing our client artifacts.
+1 findbugs 44 trunk passed
+1 javadoc 24 trunk passed
_ Patch Compile Tests _
+1 mvninstall 28 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
-0 checkstyle 17 hadoop-tools/hadoop-aws: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 mvnsite 30 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 806 patch has no errors when building and testing our client artifacts.
+1 findbugs 52 the patch passed
+1 javadoc 21 the patch passed
_ Other Tests _
+1 unit 277 hadoop-aws in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
3397
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-619/1/artifact/out/Dockerfile
GITHUB PR #619
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 13743ef0dc14 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5f6e225
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-619/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-619/1/testReport/
Max. process+thread count 344 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-619/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran
HADOOP-16197 S3ATestUtils.translateException to map CredentialInitial…
be86945 
…izationException to AccessDeniedException

Change-Id: Ie98ca5210bf0009f297edbcacf1fc6dfe5ea70cd
@steveloughran steveloughran force-pushed the s3/HADOOP-16197-translateException branch from f989369 to be86945 Compare March 22, 2019 11:53
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 22 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1084 trunk passed
+1 compile 31 trunk passed
+1 checkstyle 21 trunk passed
+1 mvnsite 35 trunk passed
+1 shadedclient 761 branch has no errors when building and testing our client artifacts.
+1 findbugs 48 trunk passed
+1 javadoc 23 trunk passed
_ Patch Compile Tests _
+1 mvninstall 30 the patch passed
+1 compile 30 the patch passed
+1 javac 30 the patch passed
-0 checkstyle 17 hadoop-tools/hadoop-aws: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 mvnsite 35 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 766 patch has no errors when building and testing our client artifacts.
+1 findbugs 56 the patch passed
+1 javadoc 22 the patch passed
_ Other Tests _
+1 unit 272 hadoop-aws in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
3359
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-619/2/artifact/out/Dockerfile
GITHUB PR #619
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux f41d6253cfa4 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ae2eb2d
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-619/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-619/2/testReport/
Max. process+thread count 340 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-619/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran added the fs/s3 changes related to hadoop-aws; submitter must declare test endpoint label Mar 28, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 26 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1015 trunk passed
+1 compile 33 trunk passed
+1 checkstyle 23 trunk passed
+1 mvnsite 37 trunk passed
+1 shadedclient 715 branch has no errors when building and testing our client artifacts.
+1 findbugs 40 trunk passed
+1 javadoc 21 trunk passed
_ Patch Compile Tests _
+1 mvninstall 28 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 16 the patch passed
+1 mvnsite 31 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 676 patch has no errors when building and testing our client artifacts.
+1 findbugs 49 the patch passed
+1 javadoc 23 the patch passed
_ Other Tests _
+1 unit 276 hadoop-aws in the patch passed.
+1 asflicense 29 The patch does not generate ASF License warnings.
3127
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-619/3/artifact/out/Dockerfile
GITHUB PR #619
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c1c4f7d7244f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 002dcc4
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-619/3/testReport/
Max. process+thread count 410 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-619/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

ajfabbri
ajfabbri approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@ajfabbri ajfabbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@bgaborg
Copy link

bgaborg commented Apr 4, 2019

I arrived a little late but +1 (non-binding)

@steveloughran
Copy link
Contributor Author

thanks for all your comments, merging

@steveloughran steveloughran changed the title HADOOP-16197 S3ATestUtils.translateException to map CredentialInitializationException to AccessDeniedException HADOOP-16197 S3AUtils.translateException to map CredentialInitializationException to AccessDeniedException Apr 4, 2019
@steveloughran
Copy link
Contributor Author

merged

@steveloughran steveloughran deleted the s3/HADOOP-16197-translateException branch August 8, 2019 11:05
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@Sanil15 @sborya
SAMZA-1817: Long classpath support for non-split deployments
ed621b2 
https://jira.apache.org/jira/browse/SAMZA-1817

Author: Sanil Jain <snjain@linkedin.com>

Reviewers: Shanthoosh Venkataraman <spvenkat@usc.edu>, Boris Shkolnik <boryas@apache.org>

Closes apache#619 from Sanil15/SAMZA-1817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajfabbri ajfabbri ajfabbri approved these changes

@noslowerdna noslowerdna noslowerdna approved these changes

Assignees
No one assigned
Labels
fs/s3 changes related to hadoop-aws; submitter must declare test endpoint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steveloughran @hadoop-yetus @bgaborg @ajfabbri @noslowerdna