HDFS-17231.HA: Safemode should exit when resources are from low to available #6207

gp1314 · 2023-10-20T07:38:54Z

Description of PR

The NameNodeResourceMonitor automatically enters safe mode when it detects that the resources are not sufficient. When zkfc detects insufficient resources, it triggers failover. Consider the following scenario:

Initially, nn01 is active and nn02 is standby. Due to insufficient resources in dfs.namenode.name.dir, the NameNodeResourceMonitor detects the resource issue and puts nn01 into safemode. Subsequently, zkfc triggers failover.
At this point, nn01 is in safemode (ON) and standby, while nn02 is in safemode (OFF) and active.
After a period of time, the resources in nn01's dfs.namenode.name.dir recover, causing a slight instability and triggering failover again.
Now, nn01 is in safe mode (ON) and active, while nn02 is in safe mode (OFF) and standby.
However, since nn01 is active but in safemode (ON), hdfs cannot be read from or written to.

reproduction

Increase the dfs.namenode.resource.du.reserved
Increase the ha.health-monitor.check-interval.ms can avoid directly switching to standby and stopping the NameNodeResourceMonitor thread. Instead, it is necessary to wait for the NameNodeResourceMonitor to enter safe mode before switching to standby.
On the nn01 active node, using the dd command to create a file that exceeds the threshold, triggering a low on available disk space condition.
If the nn01 namenode process is not dead, the situation of nn01 safemode (ON) and standby occurs.

How was this patch tested?

unit test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2023-10-20T12:39:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 55s		trunk passed
+1 💚	compile	0m 51s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 45s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 45s		trunk passed
+1 💚	mvnsite	0m 54s		trunk passed
-1 ❌	javadoc	0m 48s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
+1 💚	javadoc	1m 7s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 55s		trunk passed
+1 💚	shadedclient	21m 53s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s		the patch passed
+1 💚	compile	0m 45s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 45s		the patch passed
+1 💚	compile	0m 41s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		the patch passed
+1 💚	mvnsite	0m 46s		the patch passed
-1 ❌	javadoc	0m 38s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
+1 💚	javadoc	1m 15s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	2m 22s		the patch passed
+1 💚	shadedclient	26m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	200m 47s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		299m 38s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
	hadoop.hdfs.TestFileLengthOnClusterRestart
	hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
	hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
	hadoop.hdfs.security.TestDelegationToken
	hadoop.hdfs.TestDistributedFileSystem
	hadoop.hdfs.TestViewDistributedFileSystem
	hadoop.hdfs.TestSafeMode
	hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
	hadoop.hdfs.TestSafeModeWithStripedFile
	hadoop.hdfs.server.namenode.TestBackupNode
	hadoop.hdfs.TestGetBlocks
	hadoop.hdfs.TestLeaseRecovery

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/1/artifact/out/Dockerfile
GITHUB PR	#6207
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux a901ab960f90 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `410d3e5`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/1/testReport/
Max. process+thread count	3973 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-21T19:26:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 27s		trunk passed
+1 💚	compile	1m 3s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 55s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 55s		trunk passed
+1 💚	mvnsite	0m 59s		trunk passed
-1 ❌	javadoc	0m 52s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
+1 💚	javadoc	1m 17s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 59s		trunk passed
+1 💚	shadedclient	24m 48s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 47s		the patch passed
+1 💚	compile	0m 43s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 43s		the patch passed
+1 💚	compile	0m 39s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		the patch passed
+1 💚	mvnsite	0m 43s		the patch passed
-1 ❌	javadoc	0m 35s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
+1 💚	javadoc	0m 59s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 47s		the patch passed
+1 💚	shadedclient	24m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	199m 5s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		300m 25s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestViewDistributedFileSystem
	hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
	hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
	hadoop.hdfs.server.namenode.TestListCorruptFileBlocks
	hadoop.hdfs.TestGetBlocks
	hadoop.hdfs.security.TestDelegationToken
	hadoop.hdfs.TestSafeMode
	hadoop.hdfs.TestDistributedFileSystem
	hadoop.hdfs.TestSafeModeWithStripedFile
	hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
	hadoop.hdfs.TestLeaseRecovery
	hadoop.hdfs.TestFileLengthOnClusterRestart

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6207/1/artifact/out/Dockerfile
GITHUB PR	#6207
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux de0d0615c254 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `410d3e5`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6207/1/testReport/
Max. process+thread count	3481 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6207/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

xinglin

Good catch on the missing function to exit from safe mode when resource becomes available again. Clearly, the original author forgot to implement this function in code, while only mentioning this in the comment.

If resources are later found to have returned to acceptable levels, this daemon will cause the NN to exit safe mode.

haiyang1987 · 2023-10-22T01:44:21Z

LGTM. +1

Hexiaoqiao

LGTM. +1 from my side. Thanks @gp1314 for your great catch. I try to trigger Yetus manually, Let's wait what it will say.

hadoop-yetus · 2023-10-23T16:32:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 36s		trunk passed
+1 💚	compile	0m 53s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 48s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 45s		trunk passed
+1 💚	mvnsite	0m 52s		trunk passed
-1 ❌	javadoc	0m 51s	/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
+1 💚	javadoc	1m 10s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 55s		trunk passed
+1 💚	shadedclient	21m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s		the patch passed
+1 💚	compile	0m 46s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 46s		the patch passed
+1 💚	compile	0m 40s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 40s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 33s		the patch passed
+1 💚	mvnsite	0m 45s		the patch passed
-1 ❌	javadoc	0m 38s	/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.txt	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04.
+1 💚	javadoc	1m 3s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
-1 ❌	spotbugs	1m 52s	/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html	hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	shadedclient	21m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	194m 35s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		288m 18s

Reason	Tests
SpotBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.FSNamesystem.manualSafeMode; locked 75% of time Unsynchronized access at FSNamesystem.java:75% of time Unsynchronized access at FSNamesystem.java:[line 4538]
	Inconsistent synchronization of org.apache.hadoop.hdfs.server.namenode.FSNamesystem.resourceLowSafeMode; locked 75% of time Unsynchronized access at FSNamesystem.java:75% of time Unsynchronized access at FSNamesystem.java:[line 4538]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/3/artifact/out/Dockerfile
GITHUB PR	#6207
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 67b14dfd6a23 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9cc24f8`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/3/testReport/
Max. process+thread count	3174 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

…ailable

gp1314 · 2023-10-24T07:40:24Z

Thank you very much @haiyang1987 for fixing the issue #6214. I have rebased trunk and now I am unable to proceed with the jenkins/pr-merge step as it is giving an error "Could not checkout". I wanted to ask, what should I do now? Do I need to open a new pull request?

hadoop-yetus · 2023-10-24T12:35:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 34s		trunk passed
+1 💚	compile	0m 54s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 48s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 46s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 49s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 8s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	2m 3s		trunk passed
+1 💚	shadedclient	22m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 41s		the patch passed
+1 💚	compile	0m 46s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 46s		the patch passed
+1 💚	compile	0m 42s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		the patch passed
+1 💚	mvnsite	0m 45s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 2s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 55s		the patch passed
+1 💚	shadedclient	21m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	197m 36s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 36s		The patch does not generate ASF License warnings.
		291m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/5/artifact/out/Dockerfile
GITHUB PR	#6207
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 14515a355ac3 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8fce419`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/5/testReport/
Max. process+thread count	3572 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6207/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao · 2023-10-25T03:43:41Z

Committed to trunk. Thanks @gp1314 for your works and @xinglin for your reviews!

…vailable. (apache#6207). Contributed by Gu Peng. Reviewed-by: Xing Lin <xinglin@linkedin.com> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>

github-actions bot added HDFS trunk labels Oct 20, 2023

xinglin approved these changes Oct 21, 2023

View reviewed changes

Hexiaoqiao approved these changes Oct 23, 2023

View reviewed changes

gp1314 force-pushed the dev/gup/leave_safemode_auto branch from 410d3e5 to 9cc24f8 Compare October 23, 2023 11:43

HDFS-17231.HA: Safemode should exit when resources are from low to av…

8fce419

…ailable

gp1314 force-pushed the dev/gup/leave_safemode_auto branch from 9cc24f8 to 8fce419 Compare October 24, 2023 03:52

Hexiaoqiao merged commit a170d58 into apache:trunk Oct 25, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17231.HA: Safemode should exit when resources are from low to available #6207

HDFS-17231.HA: Safemode should exit when resources are from low to available #6207

gp1314 commented Oct 20, 2023 •

edited

Loading

hadoop-yetus commented Oct 20, 2023

hadoop-yetus commented Oct 21, 2023

xinglin left a comment

haiyang1987 commented Oct 22, 2023

Hexiaoqiao left a comment

hadoop-yetus commented Oct 23, 2023

gp1314 commented Oct 24, 2023

hadoop-yetus commented Oct 24, 2023

Hexiaoqiao commented Oct 25, 2023

HDFS-17231.HA: Safemode should exit when resources are from low to available #6207

HDFS-17231.HA: Safemode should exit when resources are from low to available #6207

Conversation

gp1314 commented Oct 20, 2023 • edited Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Oct 20, 2023

hadoop-yetus commented Oct 21, 2023

xinglin left a comment

Choose a reason for hiding this comment

haiyang1987 commented Oct 22, 2023

Hexiaoqiao left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Oct 23, 2023

gp1314 commented Oct 24, 2023

hadoop-yetus commented Oct 24, 2023

Hexiaoqiao commented Oct 25, 2023

gp1314 commented Oct 20, 2023 •

edited

Loading