Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-17310. DiskBalancer: Enhance the log message for submitPlan #6391

Merged
merged 2 commits into from
Jan 3, 2024
Merged

HDFS-17310. DiskBalancer: Enhance the log message for submitPlan #6391

merged 2 commits into from
Jan 3, 2024

Conversation

haiyang1987
Copy link
Contributor

Description of PR

https://issues.apache.org/jira/browse/HDFS-17310

In order to convenient troubleshoot problems, enhance the log message for submitPlan.

slfan1989
slfan1989 reviewed Dec 29, 2023
View reviewed changes
...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DiskBalancer.java Outdated
@@ -443,7 +444,7 @@ private NodePlan verifyPlanHash(String planID, String plan)
throws DiskBalancerException {
final long sha1Length = 40;
if (plan == null || plan.length() == 0) {
LOG.error("Disk Balancer - Invalid plan.");
LOG.error("Disk Balancer - Invalid plan ().");
Copy link
Contributor

@slfan1989 slfan1989 Dec 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be missing some information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slfan1989 for your comment.
here no need to modify it，i will remove ‘()’

@haiyang1987
Copy link
Contributor Author

Hi @tasanuma Can you help to take a review this small changes when you have time? thank you very much~

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 33s trunk passed
+1 💚 compile 1m 19s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 compile 1m 13s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 checkstyle 1m 7s trunk passed
+1 💚 mvnsite 1m 23s trunk passed
+1 💚 javadoc 1m 4s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 1m 38s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 spotbugs 3m 10s trunk passed
+1 💚 shadedclient 34m 24s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 10s the patch passed
+1 💚 compile 1m 12s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javac 1m 12s the patch passed
+1 💚 compile 1m 5s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 javac 1m 5s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 56s the patch passed
+1 💚 mvnsite 1m 13s the patch passed
+1 💚 javadoc 0m 52s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 1m 29s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 spotbugs 3m 11s the patch passed
+1 💚 shadedclient 34m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 208m 41s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
354m 57s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6391/1/artifact/out/Dockerfile
GITHUB PR #6391
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 00d50bf38832 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / dfc915e
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6391/1/testReport/
Max. process+thread count 3645 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6391/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@haiyang1987
Copy link
Contributor Author

Thanks @slfan1989 @ashutoshcipher help me reivew it.
Could you mind to push this modification forward when you have free time ? Thank you very much.

@slfan1989
Copy link
Contributor

Thanks @slfan1989 @ashutoshcipher help me reivew it.
Could you mind to push this modification forward when you have free time ? Thank you very much.

@haiyang1987 Thanks for the contribution! LGTM.

But do we wait 1-2 working days for tasanuma to help review the PR?

cc:@ashutoshcipher

tasanuma
tasanuma approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late.
LGTM. +1.

@slfan1989 slfan1989 merged commit 7a7db7f into apache:trunk Jan 3, 2024
1 of 3 checks passed
@slfan1989
Copy link
Contributor

@haiyang1987 Thank you for your contribution! Merged Into trunk. @ashutoshcipher @tasanuma Thanks for reviewing the code!

@haiyang1987
Copy link
Contributor Author

Thanks @slfan1989 @tasanuma @ashutoshcipher for your review and merge it!

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
@haiyang1987 @jiajunmao
HDFS-17310. DiskBalancer: Enhance the log message for submitPlan (apa…
aa3aa43 
…che#6391) Contributed by Haiyang Hu.

Reviewed-by: Ashutosh Gupta <ashugpt@amazon.com>
Reviewed-by: Takanobu Asanuma <tasanuma@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasanuma tasanuma tasanuma approved these changes

@ashutoshcipher ashutoshcipher ashutoshcipher approved these changes

@slfan1989 slfan1989 slfan1989 approved these changes

Assignees
No one assigned
Labels
HDFS trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haiyang1987 @hadoop-yetus @slfan1989 @tasanuma @ashutoshcipher