Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3.3) Revert "HADOOP-16822. Provide source artifacts for hadoop-client-api" #6719

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 10, 2024

This backport #6458 to branch-3.3

This reverts commit 2c4ab72.

Justification: this was making debugging through IDEs worse, rather than better.

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

… Contributed by Karel Kolman." (apache#6458)

This reverts commit 2c4ab72.

Justification: this was making debugging through IDEs worse, rather than better.
@pan3793
Copy link
Member Author

pan3793 commented Apr 10, 2024

cc @steveloughran

@steveloughran steveloughran self-assigned this Apr 10, 2024
@steveloughran
Copy link
Contributor

thanks; let's see what yetus says.

+1 pending that

@pan3793
Copy link
Member Author

pan3793 commented Apr 10, 2024

@steveloughran One thing not related to this patch. I saw lots of Hadoop ecosystem projects using Yetus, but its comments are too too too long, actually, GitHub supports the collapsed format, which may improve the reviewer experience.

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections

@steveloughran
Copy link
Contributor

@pan3793 interesting...though it's probably a yetus change. on long-lived patches I sometimes just delete the old ones, as really its only the last one or two which are of any relevance whatsoever

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 51m 4s branch-3.3 passed
+1 💚 compile 0m 23s branch-3.3 passed
+1 💚 mvnsite 0m 27s branch-3.3 passed
+1 💚 javadoc 0m 26s branch-3.3 passed
+1 💚 shadedclient 91m 35s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 7m 23s the patch passed
+1 💚 compile 0m 14s the patch passed
+1 💚 javac 0m 14s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 16s the patch passed
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedclient 41m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 16s hadoop-client-api in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
158m 18s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6719/1/artifact/out/Dockerfile
GITHUB PR #6719
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 5f70c20b1298 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / b3e676f
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6719/1/testReport/
Max. process+thread count 602 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-api U: hadoop-client-modules/hadoop-client-api
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6719/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit e2945e9 into apache:branch-3.3 Apr 11, 2024
0 of 2 checks passed
@steveloughran
Copy link
Contributor

thanks, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants