Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19159. Fix document for fs.s3a.committer.abort.pending.uploads #6778

Conversation

jshmchenxi
Copy link
Contributor

Description of PR

The description about fs.s3a.committer.abort.pending.uploads in the section Concurrent Jobs writing to the same destination is not all correct. Its default value is true.

How was this patch tested?

Minor document change, not involving tests.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

The description about `fs.s3a.committer.abort.pending.uploads` in the section `Concurrent Jobs writing to the same destination` is not all correct. Its default value is `true`.
@jshmchenxi
Copy link
Contributor Author

cc @steveloughran Please take a look, thanks!

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 19m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 50m 43s trunk passed
+1 💚 mvnsite 0m 46s trunk passed
+1 💚 shadedclient 90m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 33s the patch passed
+1 💚 shadedclient 38m 46s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
154m 34s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6778/1/artifact/out/Dockerfile
GITHUB PR #6778
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname Linux 36acb33c0a21 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 799a3b4
Max. process+thread count 527 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6778/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 00s No case conflicting files found.
+0 🆗 codespell 0m 00s codespell was not available.
+0 🆗 detsecrets 0m 00s detect-secrets was not available.
+0 🆗 markdownlint 0m 00s markdownlint was not available.
+1 💚 @author 0m 01s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 93m 07s trunk passed
+1 💚 mvnsite 5m 08s trunk passed
+1 💚 shadedclient 231m 55s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 mvnsite 2m 26s the patch passed
+1 💚 shadedclient 149m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 59s The patch does not generate ASF License warnings.
400m 35s
Subsystem Report/Notes
GITHUB PR #6778
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname MINGW64_NT-10.0-17763 485ce80da413 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 799a3b4
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6778/2/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@steveloughran steveloughran merged commit aa169e1 into apache:trunk Apr 29, 2024
3 of 5 checks passed
asfgit pushed a commit that referenced this pull request Apr 29, 2024
…g.uploads (#6778)

The description of `fs.s3a.committer.abort.pending.uploads` in the section `Concurrent Jobs writing to the same destination` is not correct. Its default value is `true`.

Contributed by Xi Chen
steveloughran pushed a commit that referenced this pull request Apr 30, 2024
…g.uploads (#6778)

The description of `fs.s3a.committer.abort.pending.uploads` in the section `Concurrent Jobs writing to the same destination` is not correct. Its default value is `true`.

Contributed by Xi Chen
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
…g.uploads (apache#6778)


The description of `fs.s3a.committer.abort.pending.uploads` in the section `Concurrent Jobs writing to the same destination` is not correct. Its default value is `true`.

Contributed by Xi Chen
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
…g.uploads (apache#6778)


The description of `fs.s3a.committer.abort.pending.uploads` in the section `Concurrent Jobs writing to the same destination` is not correct. Its default value is `true`.

Contributed by Xi Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants