Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19170. Fixes compilation issues on Mac #6822

Merged
merged 1 commit into from
May 14, 2024

Conversation

zhengchenyu
Copy link
Contributor

Description of PR

When I build hadoop-common native in Mac OS, I found this error:

/xxxxx/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/exception.c:114:50: error: function-like macro '__GLIBC_PREREQ' is not defined
#if defined(__sun) || defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 32)
The reason is that Mac OS does not support glibc. And C conditional compilation requires validation of all expressions.

How was this patch tested?

Compile on Linux and Mac OS

For code changes:

  • Fixes compilation issues on non-Linux systems

@zhengchenyu
Copy link
Contributor Author

@iwasakims Can you please review this PR?

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provisional +1 from me, though someone who is up to date with C should really review.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 28s trunk passed
+1 💚 compile 8m 48s trunk passed
+1 💚 mvnsite 1m 4s trunk passed
+1 💚 shadedclient 68m 14s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 32s the patch passed
+1 💚 compile 8m 49s the patch passed
+1 💚 cc 8m 49s the patch passed
+1 💚 golang 8m 49s the patch passed
+1 💚 javac 8m 49s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 3s the patch passed
+1 💚 shadedclient 23m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 17m 13s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
142m 36s
Reason Tests
Failed junit tests hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec
hadoop.service.launcher.TestServiceInterruptHandling
hadoop.crypto.TestCryptoCodec
hadoop.net.TestSocketIOWithTimeout
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6822/1/artifact/out/Dockerfile
GITHUB PR #6822
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux 602f01f5a48f 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f855020
Default Java Red Hat, Inc.-1.8.0_412-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6822/1/testReport/
Max. process+thread count 1847 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6822/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang changed the title HADOOP-19170. Fixes compilation issues on non-Linux systems HADOOP-19170. Fixes compilation issues on Mac May 13, 2024
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jojochuang jojochuang merged commit 4cb4d5d into apache:trunk May 14, 2024
1 of 3 checks passed
@steveloughran
Copy link
Contributor

can we pull into branch-3.4?

@zhengchenyu
Copy link
Contributor Author

@steveloughran OK, I add #6827 for backport to branch-3.4.

steveloughran pushed a commit that referenced this pull request May 15, 2024
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
)

Reviewed-by: Steve Loughran <stevel@apache.org>
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
)

Reviewed-by: Steve Loughran <stevel@apache.org>
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
ChenSammi pushed a commit to ChenSammi/hadoop that referenced this pull request Nov 18, 2024
)

Reviewed-by: Steve Loughran <stevel@apache.org>
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 4cb4d5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants