-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19170. Fixes compilation issues on Mac #6822
Conversation
@iwasakims Can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provisional +1 from me, though someone who is up to date with C should really review.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can we pull into branch-3.4? |
@steveloughran OK, I add #6827 for backport to branch-3.4. |
Contributed by zhengchenyu
) Reviewed-by: Steve Loughran <stevel@apache.org> Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org> (cherry picked from commit 4cb4d5d)
Description of PR
When I build hadoop-common native in Mac OS, I found this error:
/xxxxx/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/exception.c:114:50: error: function-like macro '__GLIBC_PREREQ' is not defined
#if defined(__sun) || defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 32)
The reason is that Mac OS does not support glibc. And C conditional compilation requires validation of all expressions.
How was this patch tested?
Compile on Linux and Mac OS
For code changes: