HDDS-1224. Restructure code to validate the response from server in the Read path. #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents discussed offline.
|
💔 -1 overall
This message was automatically generated. |
jiwq
suggested changes
May 7, 2019
| @Override | ||
| public void connect() throws Exception { | ||
| */ | ||
| @Override public void connect() throws Exception { |
There was a problem hiding this comment.
What's the purpose of modifying it?
| boolean isEmpty() { | ||
| return streamEntries.isEmpty(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
Should better add a new line at the end of file.
There was a problem hiding this comment.
These are changes from a different patch altogether and not related to the issue.
| */ | ||
| public class BlockOutputStreamEntryPool { | ||
|
|
||
| public static final Logger LOG = |
There was a problem hiding this comment.
Suggested change
| public static final Logger LOG = | |
| private static final Logger LOG = |
| @@ -83,15 +85,15 @@ | |||
| * data nodes. | |||
| * | |||
| * @param pipeline - Pipeline that defines the machines. | |||
| * @param config -- Ozone Config | |||
| * @param config -- Ozone Config | |||
There was a problem hiding this comment.
Suggested change
| * @param config -- Ozone Config | |
| * @param config - Ozone Config |
| @@ -69,7 +71,8 @@ | |||
| * The underlying RPC mechanism can be chosen via the constructor. | |||
| */ | |||
| public final class XceiverClientRatis extends XceiverClientSpi { | |||
| static final Logger LOG = LoggerFactory.getLogger(XceiverClientRatis.class); | |||
| public static final Logger LOG = | |||
There was a problem hiding this comment.
Suggested change
| public static final Logger LOG = | |
| private static final Logger LOG = |
| @@ -121,12 +121,12 @@ | |||
| TimeDuration.valueOf(3000, TimeUnit.MILLISECONDS); | |||
| public static final String DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_KEY = | |||
| "dfs.ratis.client.request.max.retries"; | |||
| public static final int DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_DEFAULT = 20; | |||
| public static final int DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_DEFAULT = 180; | |||
There was a problem hiding this comment.
What's the purpose of modifying it?
|
Closing this pull request, will create a new one to address the issue. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Jagadish <jvenkatraman@linkedin.com> Reviewers: Jagadish<jagadish@apache.org> Closes apache#793 from vjagadish1989/website-reorg30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.