HBASE-23980 Use enforcer plugin to print JVM info in maven output #1313

ndimiduk · 2020-03-19T23:56:50Z

Does what it says on the tin. Bound to initialize phase so that it
runs early in lifecycle. Uses <inherited>false</inherited> so that
the plugin will run only for the base pom's reactor stage and not for
any children.

Apache-HBase · 2020-03-20T00:24:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 12s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		18m 46s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense hadoopcheck xml
uname	Linux d327515c95f8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `26b31e3`
Max. process+thread count	76 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-20T03:58:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 34s	master passed
+1 💚	compile	4m 29s	master passed
-1 ❌	shadedjars	0m 10s	branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 22s	root in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 26s	the patch passed
+1 💚	compile	4m 23s	the patch passed
+1 💚	javac	4m 23s	the patch passed
-1 ❌	shadedjars	0m 9s	patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	204m 16s	root in the patch passed.
		233m 11s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1313
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4b100564b652 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `26b31e3`
Default Java	2020-01-14
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/testReport/
Max. process+thread count	5571 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-20T04:11:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 32s	master passed
+1 💚	compile	3m 33s	master passed
+1 💚	shadedjars	5m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 1s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 55s	the patch passed
+1 💚	compile	4m 1s	the patch passed
+1 💚	javac	4m 1s	the patch passed
+1 💚	shadedjars	6m 32s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 6s	the patch passed
		_ Other Tests _
+1 💚	unit	202m 17s	root in the patch passed.
		246m 10s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1313
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c928192eb24a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `26b31e3`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/testReport/
Max. process+thread count	5453 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Does what it says on the tin. Bound to `initialize` phase so that it runs early in lifecycle. Uses `<inherited>false</inherited>` so that the plugin will run only for the base pom's reactor stage and not for any children. Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>

Apache-HBase · 2020-03-23T21:44:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 23s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		18m 59s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1313
Optional Tests	dupname asflicense hadoopcheck xml
uname	Linux 938a9ee08beb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2f26d8a`
Max. process+thread count	76 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-23T22:17:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 22s	master passed
+1 💚	compile	3m 21s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 29s	the patch passed
+1 💚	compile	3m 34s	the patch passed
+1 💚	javac	3m 34s	the patch passed
+1 💚	shadedjars	7m 1s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	root in the patch failed.
		_ Other Tests _
-1 ❌	unit	14m 45s	root in the patch failed.
		51m 43s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1313
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 56ae4c6d6163 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2f26d8a`
Default Java	1.8.0_232
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-root.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/testReport/
Max. process+thread count	812 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1313/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2020-03-23T22:48:54Z

Thanks for the reviews, @virajjasani , @HorizonNet .

virajjasani approved these changes Mar 20, 2020

View reviewed changes

HorizonNet approved these changes Mar 20, 2020

View reviewed changes

ndimiduk force-pushed the 23980-enforcer-display-info branch from ae61bd9 to 8945d29 Compare March 23, 2020 21:22

ndimiduk merged commit af4fdcc into apache:master Mar 23, 2020

ndimiduk deleted the 23980-enforcer-display-info branch March 23, 2020 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23980 Use enforcer plugin to print JVM info in maven output #1313

HBASE-23980 Use enforcer plugin to print JVM info in maven output #1313

ndimiduk commented Mar 19, 2020

Apache-HBase commented Mar 20, 2020

Apache-HBase commented Mar 20, 2020

Apache-HBase commented Mar 20, 2020

virajjasani left a comment

Apache-HBase commented Mar 23, 2020

Apache-HBase commented Mar 23, 2020

ndimiduk commented Mar 23, 2020

HBASE-23980 Use enforcer plugin to print JVM info in maven output #1313

HBASE-23980 Use enforcer plugin to print JVM info in maven output #1313

Conversation

ndimiduk commented Mar 19, 2020

Apache-HBase commented Mar 20, 2020

Apache-HBase commented Mar 20, 2020

Apache-HBase commented Mar 20, 2020

virajjasani left a comment

Choose a reason for hiding this comment

Apache-HBase commented Mar 23, 2020

Apache-HBase commented Mar 23, 2020

ndimiduk commented Mar 23, 2020