HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1483

pankaj72981 · 2020-04-10T09:20:23Z

maxPoolSize should be logged as a plain number.

Apache-HBase · 2020-04-10T10:42:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.2 Compile Tests _
+1 💚	mvninstall	7m 14s	branch-2.2 passed
+1 💚	compile	0m 25s	branch-2.2 passed
+1 💚	checkstyle	0m 35s	branch-2.2 passed
+1 💚	shadedjars	5m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2.2 passed
+0 🆗	spotbugs	1m 8s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 5s	branch-2.2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 4s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	26m 51s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚	javadoc	0m 24s	the patch passed
+1 💚	findbugs	1m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 37s	hbase-common in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		72m 3s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/1/artifact/out/Dockerfile
GITHUB PR	#1483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5d42a934fdc8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1483/out/precommit/personality/provided.sh
git revision	branch-2.2 / `a521a80`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/1/testReport/
Max. process+thread count	344 (vs. ulimit of 10000)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

anoopsjohn

+1

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferPool.java

Apache-HBase · 2020-04-11T17:24:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-2.2 Compile Tests _
+1 💚	mvninstall	6m 7s	branch-2.2 passed
+1 💚	compile	0m 24s	branch-2.2 passed
+1 💚	checkstyle	0m 31s	branch-2.2 passed
+1 💚	shadedjars	4m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	branch-2.2 passed
+0 🆗	spotbugs	0m 59s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 57s	branch-2.2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 31s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	23m 20s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2.
+1 💚	javadoc	0m 22s	the patch passed
-1 ❌	findbugs	1m 6s	hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	unit	3m 7s	hbase-common in the patch passed.
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		63m 35s

Reason	Tests
FindBugs	module:hbase-common
	Result of integer multiplication cast to long in new org.apache.hadoop.hbase.io.ByteBufferPool(int, int, boolean) At ByteBufferPool.java:to long in new org.apache.hadoop.hbase.io.ByteBufferPool(int, int, boolean) At ByteBufferPool.java:[line 84]

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/2/artifact/out/Dockerfile
GITHUB PR	#1483
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 63da0505c951 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1483/out/precommit/personality/provided.sh
git revision	branch-2.2 / `a521a80`
Default Java	1.8.0_181
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/2/artifact/out/new-findbugs-hbase-common.html
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/2/testReport/
Max. process+thread count	265 (vs. ulimit of 10000)
modules	C: hbase-common U: hbase-common
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

binlijin

+1

Apache-HBase · 2020-04-19T08:54:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	2m 43s	Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem	Report/Notes
GITHUB PR	#1483
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-19T10:00:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	2m 13s	Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem	Report/Notes
GITHUB PR	#1483
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/4/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-20T18:43:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	2m 55s	Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem	Report/Notes
GITHUB PR	#1483
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1483/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

pankaj72981 · 2020-04-20T18:44:50Z

@binlijin Can you please help to check, why Docker failed to build?

binlijin · 2020-04-21T01:54:39Z

I do not know, @Apache9 do you have any idea? Also @pankaj72981 try a new pr for master version?

pankaj72981 · 2020-05-01T20:02:00Z

I do not know, @Apache9 do you have any idea? Also @pankaj72981 try a new pr for master version?

This issue is applicable only for branch-2.2. Have raised new PR 1624 for branch-2.2, kindly review and approve. Closing this PR now.

pankaj72981 requested a review from saintstack April 10, 2020 09:20

anoopsjohn approved these changes Apr 10, 2020

View reviewed changes

binlijin reviewed Apr 10, 2020

View reviewed changes

hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferPool.java Show resolved Hide resolved

binlijin approved these changes Apr 13, 2020

View reviewed changes

pankaj72981 added 3 commits April 19, 2020 13:39

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool

7c52bb0

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool

c22434b

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool

dbbdbbc

pankaj72981 force-pushed the HBASE-24165 branch from 154fb82 to dbbdbbc Compare April 19, 2020 08:48

pankaj72981 closed this Apr 19, 2020

pankaj72981 reopened this Apr 19, 2020

pankaj72981 closed this May 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1483

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1483

pankaj72981 commented Apr 10, 2020

Apache-HBase commented Apr 10, 2020

anoopsjohn left a comment

Apache-HBase commented Apr 11, 2020

binlijin left a comment

Apache-HBase commented Apr 19, 2020

Apache-HBase commented Apr 19, 2020

Apache-HBase commented Apr 20, 2020

pankaj72981 commented Apr 20, 2020

binlijin commented Apr 21, 2020

pankaj72981 commented May 1, 2020

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1483

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool #1483

Conversation

pankaj72981 commented Apr 10, 2020

Apache-HBase commented Apr 10, 2020

anoopsjohn left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 11, 2020

binlijin left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 19, 2020

Apache-HBase commented Apr 19, 2020

Apache-HBase commented Apr 20, 2020

pankaj72981 commented Apr 20, 2020

binlijin commented Apr 21, 2020

pankaj72981 commented May 1, 2020