Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24535: Tweak the master registry docs for branch-2 #1890

Merged
merged 1 commit into from
Jun 12, 2020
Merged

HBASE-24535: Tweak the master registry docs for branch-2 #1890

merged 1 commit into from
Jun 12, 2020

Conversation

bharathv
Copy link
Contributor

Updated to include changes in HBASE-24265 and some rewording
to make it version agnostic.

@bharathv
HBASE-24535: Tweak the master registry docs for branch-2
fa7f872 
Updated to include changes in HBASE-24265 and some rewording
to make it version agnostic.
@bharathv bharathv requested a review from ndimiduk June 12, 2020 00:08
@bharathv bharathv mentioned this pull request Jun 12, 2020
Closed
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 35s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1890
JIRA Issue HBASE-24535
Optional Tests
uname Linux 1f42e27d4713 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 42a82df
Max. process+thread count 47 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 35s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1890
JIRA Issue HBASE-24535
Optional Tests
uname Linux 65687d7a3d51 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 42a82df
Max. process+thread count 54 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 48s master passed
+0 🆗 refguide 4m 52s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+0 🆗 refguide 4m 59s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
20m 12s
Subsystem Report/Notes
Docker Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1890
JIRA Issue HBASE-24535
Optional Tests dupname asflicense refguide
uname Linux 918547c219dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 42a82df
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/artifact/yetus-general-check/output/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count 59 (vs. ulimit of 12500)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1890/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bharathv !

src/main/asciidoc/_chapters/architecture.adoc
implementation. With this change, the clients now fetch the required metadata from master RPC end
points directly. This change was done for the following reasons.
gets, etc. Traditionally, the connection registry implementation has been based on ZooKeeper as the
source of truth and clients fetched the metadata directly from the ZooKeeper quorum. HBase 2.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the ticket -- if this was backported to branch-1, this line could be updated to say "HBase 1.7.0 and 2.3.0 introduce a new connection registry implementation..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't backport the patches yet. Will do it in the coming weeks. Will revisit this section once the backport is done.

bharathv
bharathv commented Jun 12, 2020
View reviewed changes
Copy link
Contributor Author

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick review.

src/main/asciidoc/_chapters/architecture.adoc
implementation. With this change, the clients now fetch the required metadata from master RPC end
points directly. This change was done for the following reasons.
gets, etc. Traditionally, the connection registry implementation has been based on ZooKeeper as the
source of truth and clients fetched the metadata directly from the ZooKeeper quorum. HBase 2.3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't backport the patches yet. Will do it in the coming weeks. Will revisit this section once the backport is done.

@bharathv bharathv merged commit fd5002d into apache:master Jun 12, 2020
@ndimiduk
Copy link
Member

Thank you @bharathv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bharathv @Apache-HBase @ndimiduk