-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24535: Tweak the master registry docs for branch-2 #1890
Conversation
Updated to include changes in HBASE-24265 and some rewording to make it version agnostic.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bharathv !
implementation. With this change, the clients now fetch the required metadata from master RPC end | ||
points directly. This change was done for the following reasons. | ||
gets, etc. Traditionally, the connection registry implementation has been based on ZooKeeper as the | ||
source of truth and clients fetched the metadata directly from the ZooKeeper quorum. HBase 2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find the ticket -- if this was backported to branch-1, this line could be updated to say "HBase 1.7.0 and 2.3.0 introduce a new connection registry implementation..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't backport the patches yet. Will do it in the coming weeks. Will revisit this section once the backport is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick review.
implementation. With this change, the clients now fetch the required metadata from master RPC end | ||
points directly. This change was done for the following reasons. | ||
gets, etc. Traditionally, the connection registry implementation has been based on ZooKeeper as the | ||
source of truth and clients fetched the metadata directly from the ZooKeeper quorum. HBase 2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't backport the patches yet. Will do it in the coming weeks. Will revisit this section once the backport is done.
Thank you @bharathv ! |
Updated to include changes in HBASE-24265 and some rewording
to make it version agnostic.