HBASE-24600 Empty RegionAction added to MultiRequest in case of RowMu… #1938

brfrn169 · 2020-06-20T12:22:09Z

…tations/CheckAndMutate batch

Apache-HBase · 2020-06-20T12:54:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	0m 31s	master passed
+1 💚	shadedjars	6m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 58s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	shadedjars	7m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 36s	hbase-client in the patch passed.
		28m 53s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1938
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 016f30baf81d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3c31981`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/testReport/
Max. process+thread count	223 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-20T12:54:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotbugs	1m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	checkstyle	0m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	1m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		29m 13s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1938
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux dd044dece7de 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3c31981`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-20T12:56:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 41s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	shadedjars	7m 15s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 37s	hbase-client in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 56s	the patch passed
+1 💚	compile	0m 31s	the patch passed
+1 💚	javac	0m 31s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 36s	hbase-client in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 40s	hbase-client in the patch passed.
		31m 13s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1938
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5af178c18f54 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3c31981`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/testReport/
Max. process+thread count	281 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1938/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

infraio · 2020-06-21T01:24:39Z

hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java

@@ -590,7 +590,9 @@ public static void buildNoDataRegionActions(final byte[] regionName,
    if (!multiRequestBuilder.hasNonceGroup() && hasNonce) {
      multiRequestBuilder.setNonceGroup(nonceGroup);
    }
-    multiRequestBuilder.addRegionAction(builder.build());
+    if (builder.getActionCount() > 0) {


What will happen for server side if empty RegionAction added?

Thank you for taking a look at this!

Actually the server side does nothing as the RegionAction is empty. So I'd say it's not a critical bug. It will just waste network traffic a bit I think.

infraio

+1

HBASE-24600 Empty RegionAction added to MultiRequest in case of RowMu…

408eea0

…tations/CheckAndMutate batch

infraio reviewed Jun 21, 2020

View reviewed changes

infraio approved these changes Jun 24, 2020

View reviewed changes

brfrn169 merged commit 7fee4b5 into apache:master Jun 25, 2020

brfrn169 self-assigned this Jul 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24600 Empty RegionAction added to MultiRequest in case of RowMu… #1938

HBASE-24600 Empty RegionAction added to MultiRequest in case of RowMu… #1938

brfrn169 commented Jun 20, 2020

Apache-HBase commented Jun 20, 2020

Apache-HBase commented Jun 20, 2020

Apache-HBase commented Jun 20, 2020

infraio Jun 21, 2020

brfrn169 Jun 21, 2020

infraio left a comment

HBASE-24600 Empty RegionAction added to MultiRequest in case of RowMu… #1938

HBASE-24600 Empty RegionAction added to MultiRequest in case of RowMu… #1938

Conversation

brfrn169 commented Jun 20, 2020

Apache-HBase commented Jun 20, 2020

Apache-HBase commented Jun 20, 2020

Apache-HBase commented Jun 20, 2020

infraio Jun 21, 2020

Choose a reason for hiding this comment

brfrn169 Jun 21, 2020

Choose a reason for hiding this comment

infraio left a comment

Choose a reason for hiding this comment